Skip to content

Commit ea54825

Browse files
lorchidlguohan
authored andcommitted
[portsorch] Fix inconsistent return value in bindAclTable (sonic-net#791)
Signed-off-by: yorke <[email protected]>
1 parent 5984e3a commit ea54825

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

orchagent/portsorch.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -826,7 +826,7 @@ bool PortsOrch::createBindAclTableGroup(sai_object_id_t id, sai_object_id_t &gro
826826
{
827827
SWSS_LOG_ERROR("Failed to bind port %s to ACL table group %lx, rv:%d",
828828
port.m_alias.c_str(), group_oid, status);
829-
return status;
829+
return false;
830830
}
831831
break;
832832
}
@@ -842,7 +842,7 @@ bool PortsOrch::createBindAclTableGroup(sai_object_id_t id, sai_object_id_t &gro
842842
{
843843
SWSS_LOG_ERROR("Failed to bind LAG %s to ACL table group %lx, rv:%d",
844844
port.m_alias.c_str(), group_oid, status);
845-
return status;
845+
return false;
846846
}
847847
break;
848848
}
@@ -858,14 +858,14 @@ bool PortsOrch::createBindAclTableGroup(sai_object_id_t id, sai_object_id_t &gro
858858
{
859859
SWSS_LOG_ERROR("Failed to bind VLAN %s to ACL table group %lx, rv:%d",
860860
port.m_alias.c_str(), group_oid, status);
861-
return status;
861+
return false;
862862
}
863863
break;
864864
}
865865
default:
866866
{
867867
SWSS_LOG_ERROR("Failed to bind %s port with type %d", port.m_alias.c_str(), port.m_type);
868-
return SAI_STATUS_FAILURE;
868+
return false;
869869
}
870870
}
871871

0 commit comments

Comments
 (0)