Skip to content

Commit 2e40e68

Browse files
authored
Merge pull request #1759 from jsutcodes/fix/ubuntu_docker_gh_action
[WIP] Update missing CMAKE_CXX_COMPILER env in ubuntu dockerfile
2 parents dfc629b + 11fb722 commit 2e40e68

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

.github/workflows/ubuntu-24.04.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ jobs:
4141
- name: Build openage
4242
run: |
4343
sudo docker run --rm -v "$(pwd)":/mnt/openage -w /mnt/openage openage-devenv:latest \
44-
bash -c 'mkdir build && cd build && cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=$(which gcc-11) -DCMAKE_CXX_COMPILER=$(which g++-11) -DCMAKE_CXX_FLAGS='' -DCMAKE_EXE_LINKER_FLAGS='' -DCMAKE_INSTALL_PREFIX=/usr/local -DCMAKE_MODULE_LINKER_FLAGS='' -DCMAKE_SHARED_LINKER_FLAGS='' -DDOWNLOAD_NYAN=YES -DCXX_OPTIMIZATION_LEVEL=auto -DCXX_SANITIZE_FATAL=False -DCXX_SANITIZE_MODE=none -DWANT_BACKTRACE=if_available -DWANT_GPERFTOOLS_PROFILER=if_available -DWANT_GPERFTOOLS_TCMALLOC=False -DWANT_INOTIFY=if_available -DWANT_NCURSES=if_available -DWANT_OPENGL=if_available -DWANT_VULKAN=if_available -G Ninja .. && cmake --build . --parallel $(nproc) -- -k1'
44+
bash -c 'mkdir build && cd build && cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=$(which gcc) -DCMAKE_CXX_COMPILER=$(which g++) -DCMAKE_CXX_FLAGS='' -DCMAKE_EXE_LINKER_FLAGS='' -DCMAKE_INSTALL_PREFIX=/usr/local -DCMAKE_MODULE_LINKER_FLAGS='' -DCMAKE_SHARED_LINKER_FLAGS='' -DDOWNLOAD_NYAN=YES -DCXX_OPTIMIZATION_LEVEL=auto -DCXX_SANITIZE_FATAL=False -DCXX_SANITIZE_MODE=none -DWANT_BACKTRACE=if_available -DWANT_GPERFTOOLS_PROFILER=if_available -DWANT_GPERFTOOLS_TCMALLOC=False -DWANT_INOTIFY=if_available -DWANT_NCURSES=if_available -DWANT_OPENGL=if_available -DWANT_VULKAN=if_available -G Ninja .. && cmake --build . --parallel $(nproc) -- -k1'
4545
- name: Compress build artifacts
4646
run: |
4747
mkdir -p /tmp/openage

copying.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ _the openage authors_ are:
164164
| Haytham Tang | haytham918 | yunxuant à umich dawt edu |
165165
| Ana Trias-Labellarte | anatriaslabella | ana dawt triaslabella à ufl dawt edu |
166166
| Eelco Empting | Eeelco | me à eelco dawt de |
167+
| Jordan Sutton | jsutCodes | jsutcodes à gmail dawt com |
167168

168169
If you're a first-time committer, add yourself to the above list. This is not
169170
just for legal reasons, but also to keep an overview of all those nicknames.

packaging/docker/devenv/Dockerfile.ubuntu.2404

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,4 @@ RUN apt-get update && DEBIAN_FRONTEND="noninteractive" apt-get install -y sudo \
3636
qt6-multimedia-dev \
3737
qml6-module-qtquick3d-spatialaudio \
3838
&& sudo apt-get clean \
39-
&& truncate -s 0 ~/.bash_history
39+
&& truncate -s 0 ~/.bash_history

0 commit comments

Comments
 (0)