Skip to content

Need to remove push/pop/resetGLStates in RenderDrawLists #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eliasdaler opened this issue Jul 31, 2016 · 1 comment
Closed

Need to remove push/pop/resetGLStates in RenderDrawLists #9

eliasdaler opened this issue Jul 31, 2016 · 1 comment
Labels
enhancement

Comments

@eliasdaler
Copy link
Contributor

So, old ImGui-SFML binding tried to save OpenGL state without having to call SFML's push/pop/resetGLStates. But this didn't work 100% correctly. People had problems with resizing the window and some other stuff. And right now I have #8 which is probably related to this.

It's also pretty slow to call push/pop/resetGLState all the time and profiler shows that most of the time in RenderDrawLists is spent doing that.

So it'll be good to fix that. If someone has enough knowledge about SFML and/or OpenGL, please help. :D
@eliasdaler
Copy link
Contributor Author

After several hours of work, I've managed to do it! If you notice any problems with this, feel free to open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eliasdaler