Skip to content

Commit 7ee6dde

Browse files
matz3KlattG
andcommitted
[INTERNAL] Apply suggestions from code review
Co-authored-by: Günter Klatt <[email protected]>
1 parent 7bdb47a commit 7ee6dde

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

lib/graph/Workspace.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ class Workspace {
9696
* @public
9797
* @param {string} projectName Name of the project
9898
* @returns {Promise<@ui5/project/graph/Module|undefined>}
99-
* Module instance or <code>undefined</code> if none is found
99+
* Module instance, or <code>undefined</code> if none is found
100100
*/
101101
async getModuleByProjectName(projectName) {
102102
const {projectNameMap} = await this._getResolvedModules();
@@ -112,7 +112,7 @@ class Workspace {
112112
* @public
113113
* @param {string} nodeId Node ID of the module
114114
* @returns {Promise<@ui5/project/graph/Module|undefined>}
115-
* Module instance or <code>undefined</code> if none is found
115+
* Module instance, or <code>undefined</code> if none is found
116116
*/
117117
async getModuleByNodeId(nodeId) {
118118
const {moduleIdMap} = await this._getResolvedModules();

lib/specifications/Specification.js

+8-8
Original file line numberDiff line numberDiff line change
@@ -159,9 +159,9 @@ class Specification {
159159

160160
/* === Attributes === */
161161
/**
162-
* Get the ID of this specification.
162+
* Gets the ID of this specification.
163163
*
164-
* <p><b>Note: </b>Only to be used in special occasions as it specific to the provider that was used and does
164+
* <p><b>Note: </b>Only to be used for special occasions as it is specific to the provider that was used and does
165165
* not necessarily represent something defined by the project.</p>
166166
*
167167
* For general purposes of a unique identifier use
@@ -175,7 +175,7 @@ class Specification {
175175
}
176176

177177
/**
178-
* Get the name of this specification. Represents a unique identifier.
178+
* Gets the name of this specification. Represents a unique identifier.
179179
*
180180
* @public
181181
* @returns {string} Specification name
@@ -185,7 +185,7 @@ class Specification {
185185
}
186186

187187
/**
188-
* Get the kind of this specification, for example <code>project</code> or <code>extension</code>
188+
* Gets the kind of this specification, for example <code>project</code> or <code>extension</code>
189189
*
190190
* @public
191191
* @returns {string} Specification kind
@@ -195,7 +195,7 @@ class Specification {
195195
}
196196

197197
/**
198-
* Get the type of this specification,
198+
* Gets the type of this specification,
199199
* for example <code>application</code> or <code>library</code> in case of projects,
200200
* and <code>task</code> or <code>server-middleware</code> in case of extensions
201201
*
@@ -217,7 +217,7 @@ class Specification {
217217
}
218218

219219
/**
220-
* Get the specification's generic version, as typically defined in a <code>package.json</code>
220+
* Gets the specification's generic version, as typically defined in a <code>package.json</code>
221221
*
222222
* @public
223223
* @returns {string} Project version
@@ -227,7 +227,7 @@ class Specification {
227227
}
228228

229229
/**
230-
* Get the specification's file system path. This might not be POSIX-style on some platforms
230+
* Gets the specification's file system path. This might not be POSIX-style on some platforms
231231
*
232232
* @public
233233
* @returns {string} Project root path
@@ -238,7 +238,7 @@ class Specification {
238238

239239
/* === Resource Access === */
240240
/**
241-
* Get a [ReaderCollection]{@link @ui5/fs/ReaderCollection} for the root directory of the specification.
241+
* Gets a [ReaderCollection]{@link @ui5/fs/ReaderCollection} for the root directory of the specification.
242242
* Resource readers always use POSIX-style
243243
*
244244
* @public

0 commit comments

Comments
 (0)