Skip to content

Commit 6110d69

Browse files
committed
[FIX] 루틴 조회 API 그룹 루틴 알람 여부 값 형식 수정
1 parent 07286a1 commit 6110d69

File tree

3 files changed

+13
-35
lines changed

3 files changed

+13
-35
lines changed

src/main/java/org/routineade/RoutineAdeServer/dto/routine/GroupRoutineInfo.java

+3-4
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@
55
public record GroupRoutineInfo(
66
Long routineId,
77
String routineTitle,
8-
Boolean isCompletion,
9-
Boolean isAlarmEnabled
8+
Boolean isCompletion
109
) {
11-
public static GroupRoutineInfo of(Routine routine, Boolean isCompletion, Boolean isAlarmEnabled) {
12-
return new GroupRoutineInfo(routine.getRoutineId(), routine.getRoutineTitle(), isCompletion, isAlarmEnabled);
10+
public static GroupRoutineInfo of(Routine routine, Boolean isCompletion) {
11+
return new GroupRoutineInfo(routine.getRoutineId(), routine.getRoutineTitle(), isCompletion);
1312
}
1413
}

src/main/java/org/routineade/RoutineAdeServer/dto/routine/GroupRoutinesGetResponse.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,11 @@
66
public record GroupRoutinesGetResponse(
77
Long groupId,
88
String groupTitle,
9+
Boolean isAlarmEnabled,
910
List<GroupRoutinesCategoryInfo> groupRoutines
1011
) {
11-
public static GroupRoutinesGetResponse of(Group group, List<GroupRoutinesCategoryInfo> groupRoutines) {
12-
return new GroupRoutinesGetResponse(group.getGroupId(), group.getGroupTitle(), groupRoutines);
12+
public static GroupRoutinesGetResponse of(Group group, Boolean isAlarmEnabled,
13+
List<GroupRoutinesCategoryInfo> groupRoutines) {
14+
return new GroupRoutinesGetResponse(group.getGroupId(), group.getGroupTitle(), isAlarmEnabled, groupRoutines);
1315
}
1416
}

src/main/java/org/routineade/RoutineAdeServer/service/RoutineService.java

+6-29
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,6 @@
2929
import org.routineade.RoutineAdeServer.dto.routine.GroupRoutineInfo;
3030
import org.routineade.RoutineAdeServer.dto.routine.GroupRoutinesCategoryInfo;
3131
import org.routineade.RoutineAdeServer.dto.routine.GroupRoutinesGetResponse;
32-
import org.routineade.RoutineAdeServer.dto.routine.PersonalRoutineByUserProfileGetResponse;
33-
import org.routineade.RoutineAdeServer.dto.routine.PersonalRoutineByUserProfileInfo;
3432
import org.routineade.RoutineAdeServer.dto.routine.PersonalRoutineGetResponse;
3533
import org.routineade.RoutineAdeServer.dto.routine.PersonalRoutineInfo;
3634
import org.routineade.RoutineAdeServer.dto.routine.RoutineCreateRequest;
@@ -111,8 +109,8 @@ public RoutinesGetResponse getRoutines(User user, String routineDate) {
111109
}
112110

113111
groupRoutinesGetResponses.add(
114-
GroupRoutinesGetResponse.of(userGroup, createGroupRoutineCategories(user, filterRoutines,
115-
date, groupMember.getIsGroupAlarmEnabled())));
112+
GroupRoutinesGetResponse.of(userGroup, groupMember.getIsGroupAlarmEnabled(),
113+
createGroupRoutineCategories(user, filterRoutines, date)));
116114
}
117115

118116
return RoutinesGetResponse.of(personalRoutineGetResponses, groupRoutinesGetResponses,
@@ -128,8 +126,8 @@ public RoutinesByUserProfileGetResponse getRoutinesByUserProfile(Group group, Us
128126
List<Routine> filterRoutines = routineRepeatDayService.filterRoutinesByDay(routines, date.getDayOfWeek());
129127

130128
return RoutinesByUserProfileGetResponse.of(user, userEmotionService.getUserEmotionByDate(user, date),
131-
GroupRoutinesGetResponse.of(group,
132-
createGroupRoutineCategories(user, filterRoutines, date, isAlarmEnabled)));
129+
GroupRoutinesGetResponse.of(group, isAlarmEnabled,
130+
createGroupRoutineCategories(user, filterRoutines, date)));
133131
}
134132

135133
public void createRoutine(User user, RoutineCreateRequest request) {
@@ -357,7 +355,7 @@ private List<PersonalRoutineGetResponse> createPersonalRoutineCategories(User us
357355
}
358356

359357
private List<GroupRoutinesCategoryInfo> createGroupRoutineCategories(User user, List<Routine> routines,
360-
LocalDate date, Boolean isAlarmEnabled) {
358+
LocalDate date) {
361359
return Arrays.stream(Category.values())
362360
.map(category -> GroupRoutinesCategoryInfo.of(
363361
category.getLabel(),
@@ -366,31 +364,10 @@ private List<GroupRoutinesCategoryInfo> createGroupRoutineCategories(User user,
366364
|| r.getStartDate().isEqual(date)))
367365
.map(r -> GroupRoutineInfo.of(
368366
r,
369-
completionRoutineService.getIsCompletionRoutine(user, r, date),
370-
isAlarmEnabled))
371-
.toList()
372-
))
373-
.filter(grci -> !grci.routines().isEmpty())
374-
.toList();
375-
}
376-
377-
private List<PersonalRoutineByUserProfileGetResponse> createProfilePersonalRoutineCategories(User user,
378-
List<Routine> routines,
379-
LocalDate date) {
380-
return Arrays.stream(Category.values())
381-
.map(category -> PersonalRoutineByUserProfileGetResponse.of(
382-
category.getLabel(),
383-
routines.stream()
384-
.filter(r -> r.getRoutineCategory().equals(category) && (r.getStartDate().isBefore(date)
385-
|| r.getStartDate().isEqual(date)))
386-
.map(r -> PersonalRoutineByUserProfileInfo.of(
387-
r,
388-
r.getRoutineRepeatDays().stream()
389-
.map(rd -> rd.getRepeatDay().getLabel())
390-
.toList(),
391367
completionRoutineService.getIsCompletionRoutine(user, r, date)))
392368
.toList()
393369
))
370+
.filter(grci -> !grci.routines().isEmpty())
394371
.toList();
395372
}
396373

0 commit comments

Comments
 (0)