Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add pregnant man emojis and person emojis #35578

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: add pregnant man emojis and person emojis #35578

wants to merge 1 commit into from

Conversation

naman22a
Copy link

@naman22a naman22a commented Mar 21, 2025 •
edited
Loading

fix: add pregnant man emojis and person emojis

This pull request adds support for pregnant man (🫃) and pregnant person (🫄) emojis with all skin tone variations. These additions ensure better inclusivity and representation.

Proposed changes

Added the following emojis:

  • Pregnant man (🫃) with five skin tones
  • Pregnant person (🫄) with five skin tones
    Updated emoji mappings accordingly

Issue(s)

Fixes #35564

Why this change?

  • Enhances inclusivity by including all gender-based pregnancy emojis
  • Aligns with modern emoji standards
  • Improves user experience by expanding available emoji options

@naman22a naman22a requested review from a team as code owners March 21, 2025 04:57
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Mar 21, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2025

⚠️ No Changeset found

Latest commit: 02b8133

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@csc-jm
Copy link

csc-jm commented Mar 21, 2025 •
edited
Loading

I'm not too familiar with the codebase but I assume this change also needs to be added to the emojiPicker.ts file (via the generateEmojiIndex.mjs script)?

MartinSchoeler
MartinSchoeler requested changes Mar 24, 2025
View reviewed changes
Copy link
Member

@MartinSchoeler MartinSchoeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, these are the emojis codes for the livechat client, I think they are quite outdated, mind checking for more missing emojis? Thanks!

@naman22a
Copy link
Author

Hey, these are the emojis codes for the livechat client, I think they are quite outdated, mind checking for more missing emojis? Thanks!

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinSchoeler MartinSchoeler MartinSchoeler requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing pregnant man/pregnant person emoji
3 participants
@naman22a @csc-jm @MartinSchoeler