Skip to content

Commit eba7bd7

Browse files
committed
chore: add XXX note for shutting down processes
1 parent e7c08f4 commit eba7bd7

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/rai_sim/rai_sim/launch_manager.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,11 @@ def _run_process(self, stop_event, launch_description: LaunchDescription):
4242
# when stop event set
4343
loop.run_until_complete(loop.run_in_executor(None, stop_event.wait))
4444
if not launch_task.done():
45+
# XXX (jmatejcz) the shutdown function sends shutdown signal to all
46+
# nodes launch with launch description which should do the trick
47+
# but some nodes are stubborn and there is a posiibility
48+
# that they don't close. If this will happed sending PKILL for all
49+
# ros nodes will be needed
4550
shutdown_task = loop.create_task(
4651
launch_service.shutdown(),
4752
)

0 commit comments

Comments
 (0)