Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to new API for hodl invoices for better UX with Alby extension #891

Open
MoritzKa opened this issue Oct 13, 2023 · 3 comments
Open

Update to new API for hodl invoices for better UX with Alby extension #891

MoritzKa opened this issue Oct 13, 2023 · 3 comments
Assignees
@khadar1020
Labels
bug 🐛 Something isn't working good first issue Good for newcomers javascript Pull requests that update Javascript code

Comments

@MoritzKa
Copy link

Is your feature request related to a problem? Please describe.
Currently, Alby does not close when you use it to pay a hodl invoice.

Describe the solution you'd like
update webln.sendPayment to webln.sendPaymentAsync

Additional context
full API documentation and demo to test: https://www.webln.guide/building-lightning-apps/webln-reference/webln.sendpaymentasync
@Reckless-Satoshi
Copy link
Collaborator

Hey @MoritzKa Thank you for putting this in our radar and thank you too for taking the time to improve UX for hodl invoices!

@KoalaSat KoalaSat added bug 🐛 Something isn't working good first issue Good for newcomers javascript Pull requests that update Javascript code labels Feb 18, 2025
@khadar1020
Copy link
Contributor

can I work on this issue @KoalaSat

@KoalaSat
Copy link
Member

can I work on this issue @KoalaSat

All yours, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khadar1020 khadar1020

Labels
bug 🐛 Something isn't working good first issue Good for newcomers javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@MoritzKa @Reckless-Satoshi @KoalaSat @khadar1020