Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display market prices apis #1812

Open
KoalaSat opened this issue Mar 15, 2025 · 4 comments · Fixed by #1811
Open

Display market prices apis #1812

KoalaSat opened this issue Mar 15, 2025 · 4 comments · Fixed by #1811
Assignees
Labels
enhancement 🆙 New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code

Comments

@KoalaSat
Copy link
Member

Is your feature request related to a problem? Please describe.

Different Coordinators may use multiple sources to get the market price. Over these reponses, the median price is calculated and that the one the Coordinator uses to calculate satoshis. This is an useful feature for users but we don´t display it on the frontend

Describe the solution you'd like

Display these sources in Coordinator's profile and explain for the case of multiple sources, the median is calculated.

sources introduced to the API on this PR: #1811

Additional context
Coordinator's profile: https://github.com/RoboSats/robosats/blob/main/frontend/src/components/Dialogs/Coordinator.tsx

@KoalaSat KoalaSat added enhancement 🆙 New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code labels Mar 15, 2025
@KoalaSat KoalaSat reopened this Mar 15, 2025
@khadar1020
Copy link
Contributor

is this issue resolved @KoalaSat or still any work is pending

@KoalaSat
Copy link
Member Author

KoalaSat commented Mar 16, 2025

is this issue resolved @KoalaSat or still any work is pending

It''s pending to implement on frontend, but the API response is till not available (next release) the implementation is simple if you look at the PR for back end

@hexlorn
Copy link

hexlorn commented Apr 6, 2025

Hello! @KoalaSat Can you assign me this issue?

@KoalaSat
Copy link
Member Author

KoalaSat commented Apr 8, 2025

@hexlorn done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🆙 New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants