Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Claim Reward Button and improved styling of Profile.tsx #1795

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gitsofaryan
Copy link
Contributor

What does this PR do?

Fixes #1776

Description:

  • Added a "Claim Reward" button with icon in the profile header for better visibility.
  • Created an info alert that explains how to claim rewards by contacting coordinators.
  • Displays a list of relevant coordinators to help users know who to contact.

Checklist before merging

  • Install pre-commit and initialize it: pip install pre-commit, then pre-commit install. Pre-commit installs git hooks that automatically check the codebase. If pre-commit fails when you commit your changes, please fix the problems it points out.

@gitsofaryan
Copy link
Contributor Author

@KoalaSat please review my changes.

@KoalaSat
Copy link
Member

KoalaSat commented Mar 5, 2025

@gitsofaryan sorry for not being more clear on the description. Robots can have a first try to claim their rewards:

Screenshot from 2025-03-05 09-37-00

The idea was to provide this form first (I like your idea of having just one button on the top) and after the user sends its invoice, display the text about contacting coordinators if the payment doesn't arrive.

A couple of extra comments worth checking:

  • Because users will be able to claim rewards only when available, you can disable the button until you detect there is one coordinator with rewards for the user (for every coordinator: robot?.earnedRewards > 0)
  • I think it's worth to move this reward form to a separate popup that opens with the new button and remove the one on the screenshot above
  • I noticed the robot window expands its width when the text appears, careful with that :)
  • Don't forget to check for mobile view
  • Somehow the robot avatar went out of the margins
    Screenshot from 2025-03-05 09-47-04

Thank you so much for this so needed feature 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create better UX when claiming rewards
2 participants