feat(python): add support for v3.12 (#762)

This is just essentially adding tests & a classifier. The only notable
change is to avoid a deprecation warning in `prisma_cleanup`.

Author: RobertCraigie

.github/workflows/test.yml

@@ -24,7 +24,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest]
-        python-version: [3.7, 3.8, 3.9, "3.10", "3.11"]
+        python-version: [3.7, 3.8, 3.9, "3.10", "3.11", "3.12"]
         include:
           - os: ubuntu-latest
             python-version: "3.10"

pipelines/test.nox.py

@@ -6,7 +6,7 @@
 from pipelines.utils.prisma import generate
 
 
-@nox.session(python=['3.7', '3.8', '3.9', '3.10', '3.11'])
+@nox.session(python=['3.7', '3.8', '3.9', '3.10', '3.11', '3.12'])
 def test(session: nox.Session) -> None:
     setup_env(session)
     session.install('-r', 'pipelines/requirements/test.txt')

scripts/ci.py

@@ -8,6 +8,7 @@
     '3.9': '3.9',
     '3.10': '3.10',
     '3.11': '3.11',
+    '3.12': '3.12',
 }
 
 

setup.py

@@ -90,6 +90,7 @@ def requirements(name: str) -> List[str]:
         'Programming Language :: Python :: 3.9',
         'Programming Language :: Python :: 3.10',
         'Programming Language :: Python :: 3.11',
+        'Programming Language :: Python :: 3.12',
         'Operating System :: POSIX',
         'Operating System :: MacOS',
         'Operating System :: POSIX :: Linux',

src/prisma_cleanup/_cleanup.py

@@ -1,6 +1,6 @@
 import sys
-import pkgutil
 from pathlib import Path
+from importlib.util import find_spec
 from typing_extensions import Protocol, runtime_checkable
 
 PRISMA_INIT_CONTENTS = "__title__ = 'prisma'"
@@ -24,14 +24,14 @@ def main(*args: str) -> None:
 def cleanup(pkg_name: str = 'prisma') -> None:
     """Remove python files that are auto-generated by Prisma Client Python"""
 
-    # pkgutil.get_loader() can return a loader that doesn't have access to
-    # the packages source location. We should provide an easy to understand error
-    # for this case even if it is incredibly unlikey (if not impossible)
-    # to happen in our use case
-    loader = pkgutil.get_loader(pkg_name)  # pyright: ignore[reportDeprecated]
-    if loader is None:
+    spec = find_spec(pkg_name)
+    if spec is None:
         raise RuntimeError(f'Could not resolve package: {pkg_name}')
 
+    loader = spec.loader
+    if loader is None:
+        raise RuntimeError(f'No loader defined for: {pkg_name}')
+
     if not isinstance(loader, SourceLoader):
         raise RuntimeError(f'Received unresolvable import loader: {loader}')
 

tests/conftest.py

@@ -25,6 +25,8 @@
 
 prisma.register(Prisma())
 
+pytest.register_assert_rewrite('tests.test_generation.utils')
+
 
 @pytest.fixture()
 def runner(monkeypatch: 'MonkeyPatch') -> Runner:

tests/test_generation/test_prisma_cleanup.py

@@ -1,7 +1,5 @@
 import sys
-import pkgutil
 import subprocess
-from typing import TYPE_CHECKING
 
 import pytest
 from prisma_cleanup import cleanup
@@ -12,9 +10,6 @@
 from .utils import assert_module_is_clean, assert_module_not_clean
 from ..utils import Testdir
 
-if TYPE_CHECKING:
-    from _pytest.monkeypatch import MonkeyPatch
-
 
 def test_main(testdir: Testdir) -> None:
     """Main entrypoint"""
@@ -58,22 +53,6 @@ def test_main_works_with_erroneous_client(testdir: Testdir) -> None:
     assert_module_is_clean(path)
 
 
-def test_unresolvable_loader(monkeypatch: 'MonkeyPatch') -> None:
-    """pkgutil.get_loader() can return a loader that doesn't have access to
-    the packages source location.
-    """
-
-    def patched_get_loader(pkg: str) -> object:
-        return 'Dummy'
-
-    monkeypatch.setattr(pkgutil, 'get_loader', patched_get_loader)
-
-    with pytest.raises(RuntimeError) as exc:
-        cleanup()
-
-    assert exc.value.args[0] == 'Received unresolvable import loader: Dummy'
-
-
 def test_custom_package(testdir: Testdir) -> None:
     """Cleaning up custom package location"""
     path = testdir.path / 'app' / 'prisma'