Skip to content

[BUG] TournamentRegion deserialization failing for NA region on /lol/tournament/v5/games/by-code/... #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NotMiaow opened this issue May 25, 2025 · 1 comment

Comments

@NotMiaow
Copy link

Problem Description
I think suspect the Riot side enum crate::consts::TournamentRegion
silently changed NA to NA1
which is making deserialization fail for
tournament_v5().get_games(...)

Expected Result
For deserialization to succeed,
and the endpoint to resolve as usual

Actual Result

unknown variant `NA1`,
expected one of
`BR`,
`EUNE`,
`EUW`,
`JP`,
`LAN`,
`LAS`,
`NA`,
`OCE`,
`TR`,
`PBE`
at line 1 column 1235

Developer Impact

  • Frequency: Every time a tournament match is done
  • Severity: The endpoint never works for NA region
  • Cost: None
  • Efficiency: Slows down automated tournaments, or events
  • Users: Users complain they're waiting a lot

Repro Steps
call tournament_v5().get_games(...)
with RegionalRoute::NA1

Issue Comments
My tournaments are running rougher.
I can still close games myself, when I'm made aware of the result
Or my users can close the game themselves, if they hit a sufficient concensus on who won

@NotMiaow
Copy link
Author

Posted to the wrong repo, my mistake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant