-
Notifications
You must be signed in to change notification settings - Fork 42
[BUG] match-v5
fields playerAugment5
& playerAugment6
are always 0
#1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Issue: Inconsistent Null Values in
|
++ For a billion dollar company, I'd expect more importance placed in having correct endpoint documentation. The endpoint docs are littered with incorrectly filled types, lack of possible nullish instances or straight up missing fields. Consistent issue with Riot devrel for years. PS: Here's an example from a while ago; Ctrl+F "Missing from docs", both playerAugment 5 & 6 were problematic a while ago already. https://github.com/MGSimard/leaguemh-next/blob/main/src/lib/typesMatchV5.ts |
So let's develop a good API together 😍 |
Bug & Problem Description
It seems that when introducing more than 4 augments in the Arena & Swarm game mode, the
playerAugment5
&playerAugment6
field is not working as expected and returns 0 even though a player has selected a 5th/6th augment.For example, in match
NA1_5246867453
, the player playing Ziggs had 5 augments at the end of the game, but the API returns 0 forplayerAugment5
.Developer Impact
Could not find any games in our database where
playerAugment5
orplayerAugment6
is anything other than 0.The text was updated successfully, but these errors were encountered: