Fixes issues with nadar#30 Issue with multiple ul-li lists where ul-li list contains only one item (nadar#33)

* add failing test case for multiple bulletlists with only one bullet

* create an opening ul/ol tag when none have been created before

* fix indentation and typo in comments

* add failing test case for multiple bulletlists with only one bullet

create an opening ul/ol tag when none have been created before

fix indentation and typo in comments

* improved inline documentation and added a change log entry

Author: stijnster

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## 2.4.0
+
++ [#30](https://github.com/nadar/quill-delta-parser/issues/30) List opening tag process has been simplified in order to support single bullet lists.
+
 ## 2.3.0 (23. October 2019)
 
 + Add override functionality to links, allowing to customise their wrapper.

src/listener/Lists.php

@@ -75,7 +75,7 @@ public function render(Lexer $lexer)
             if ($hasNextInside) {
                 $isLast = true;
             }
-            
+
             $output = null;
 
             // this makes sure that when two list types are after each other (OL and UL)
@@ -85,17 +85,17 @@ public function render(Lexer $lexer)
                 $isOpen = false;
             }
 
-            // create the opining OL/UL tag if:
-            //  a. its not already open AND $isLast is false (which means not the last element)
-            //  b. or its the first the pick inside the picked elements list https://github.com/nadar/quill-delta-parser/issues/8
-            if ((!$isOpen && !$isLast) || (!$isOpen && $pick->isFirst())) {
+            // create the opening OL/UL tag
+            // opening tag process has been simplified, see https://github.com/nadar/quill-delta-parser/pull/33
+            // and https://github.com/nadar/quill-delta-parser/issues/30
+            if (!$isOpen) {
                 $output .= '<'.$this->getListAttribute($pick).'>';
                 $isOpen = true;
             }
 
             // write the li element.
             $output.= '<li>' . $buffer .'</li>';
-            
+
             // close the opening OL/UL tag if:
             //   a. its the last element and the tag is opened.
             //   b. or its the last element in the picked list.
@@ -128,7 +128,7 @@ protected function getListAttribute(Pick $pick)
         if ($pick->type == self::LIST_TYPE_BULLET) {
             return 'ul';
         }
-        
+
         // prevent html injection in case the attribute is user input
         throw new Exception('The provided list type "'.$pick->type.'" is not a known list type (ordered or bullet).');
     }

tests/ListSingleBulletsTest.php

@@ -0,0 +1,80 @@
+<?php
+
+namespace nadar\quill\tests;
+
+class ListSingleBullets extends DeltaTestCase
+{
+    public $json = <<<'JSON'
+[
+    {
+        "insert": "line 1\nbullet 1 - 1"
+    },
+    {
+        "attributes": {
+            "list": "bullet"
+        },
+        "insert": "\n"
+    },
+    {
+        "insert": "line 2\nbullet 2 - 1"
+    },
+    {
+        "attributes": {
+            "list": "bullet"
+        },
+        "insert": "\n"
+    },
+    {
+        "insert": "line 3\nbullet 3 - 1"
+    },
+    {
+        "attributes": {
+            "list": "bullet"
+        },
+        "insert": "\n"
+    },
+    {
+        "insert": "line 4\nbullet 4 - 1"
+    },
+    {
+        "attributes": {
+            "list": "bullet"
+        },
+        "insert": "\n"
+    },
+    {
+        "insert": "bullet 4 - 2"
+    },
+    {
+        "attributes": {
+            "list": "bullet"
+        },
+        "insert": "\n"
+    },
+    {
+        "insert": "line 5\n"
+    }
+]
+JSON;
+
+    public $html = <<<'EOT'
+<p>line 1</p>
+<ul>
+<li>bullet 1 - 1</li>
+</ul>
+<p>line 2</p>
+<ul>
+<li>bullet 2 - 1</li>
+</ul>
+<p>line 3</p>
+<ul>
+<li>bullet 3 - 1</li>
+</ul>
+<p>line 4</p>
+<ul>
+<li>bullet 4 - 1</li>
+<li>bullet 4 - 2</li>
+</ul>
+<p>line 5</p>
+EOT;
+}