Skip to content

feat(YouTube): Add Disable haptic feedback patch #5033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 27, 2025

Conversation

MarcaDian
Copy link
Contributor

@MarcaDian MarcaDian commented May 25, 2025

Adds options to disable various haptic feedback (device vibrations).

This patch replaces the existing Disable zoom haptics patch.

Adapted from here

@MarcaDian
Copy link
Contributor Author

I didn't find a haptic feedback purely for the seekbar, maybe it was in previous versions, so I removed this code.

@ILoveOpenSourceApplications
Copy link
Contributor

I didn't find a haptic feedback purely for the seekbar, maybe it was in previous versions, so I removed this code.

Probably for seekbar with chapters. Have you tried those as well?

# [5.25.0-dev.9](ReVanced/revanced-patches@v5.25.0-dev.8...v5.25.0-dev.9) (2025-05-26)

### Features

* **Spotify:** Add `Fix Facebook login` patch ([ReVanced#5023](ReVanced#5023)) ([34932dc](ReVanced@34932dc))
* **YouTube - Settings:** Add a color picker ([ReVanced#4981](ReVanced#4981)) ([1e0e398](ReVanced@1e0e398))
@MarcaDian
Copy link
Contributor Author

I didn't find a haptic feedback purely for the seekbar, maybe it was in previous versions, so I removed this code.

Probably for seekbar with chapters. Have you tried those as well?

There is a separate option to disable chapters haptics and it works.

MarcaDian and others added 3 commits May 26, 2025 12:00
@MarcaDian
Copy link
Contributor Author

MarcaDian commented May 26, 2025

Perhaps the haptic feedback of swipe controls should also be moved to this submenu?

But there is a parent setting.

@LisoUseInAIKyrios
Copy link
Contributor

I think swipe controls haptics should stay in their own menu. It's not a built in YT feature and specific to swipe controls.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(YouTube - Player): Add an option to disable haptic feedback in the player for various actions feat(YouTube): Add Disable haptic feedback patch May 26, 2025
@MarcaDian
Copy link
Contributor Author

offtop: the idea of moving patches (in the code) to their current position in the settings was raised earlier.

Not like now:

  • ad
  • interaction
  • layout
  • misk
  • shared
  • video

But like this:

  • ads
  • alternative thumbnail
  • feed
  • general
  • player
  • shorts
  • seekbar
  • swipe controls
  • ryd
  • sb
  • misc
  • video

Is it necessary to do this, because now I am confused when adding this patch, since its settings are in PLAYER, and the patch is in MISC.

@LisoUseInAIKyrios
Copy link
Contributor

Yes, the patches package structure is outdated and can be improved. Especially since it's still using the old settings menu screens that don't exist anymore.

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit bbe7974 into ReVanced:dev May 27, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request May 27, 2025
# [5.25.0-dev.11](v5.25.0-dev.10...v5.25.0-dev.11) (2025-05-27)

### Features

* **YouTube - Enable debugging:** Add settings menu to share debug logs ([#5021](#5021)) ([1ec4a88](1ec4a88))
* **YouTube:** Add `Disable haptic feedback` patch ([#5033](#5033)) ([bbe7974](bbe7974))
@MarcaDian MarcaDian deleted the haptic-feedback branch May 27, 2025 07:57
github-actions bot pushed a commit that referenced this pull request May 29, 2025
# [5.25.0](v5.24.0...v5.25.0) (2025-05-29)

### Bug Fixes

* **Disable Pairip license check:** Change patch to default off ([74b6a94](74b6a94))
* **Hide ADB status:** Resolve app crash on startup ([#5029](#5029)) ([1abebd5](1abebd5))
* **Messenger:** Remove outdated `Disable switching emoji to sticker` patch ([#5044](#5044)) ([7b182ca](7b182ca))
* **Spotify Lite:** Remove obsolete `Enable on demand` patch ([#5046](#5046)) ([4886d47](4886d47))
* **YouTube - GmsCore support:** Restore patch functionality from prior merge ([7686bbe](7686bbe))
* **YouTube - Hide ads:** Hide new type of general ad ([#5004](#5004)) ([37e59d2](37e59d2))
* **YouTube - Open Shorts in regular player:** Do not exit app when pressing back button in regular player ([#5020](#5020)) ([3384f8d](3384f8d))
* **YouTube:** Better handle incorrect duplicate translations ([20abac5](20abac5))
* **Yuka - Unlock premium:** Remove broken patch that is no longer supported ([#5018](#5018)) ([fac6e59](fac6e59))

### Features

* Add `Disable pairip license check` patch ([#4927](#4927)) ([42d2c27](42d2c27))
* **Messenger:** Add `Remove Meta AI` patch ([#4945](#4945)) ([012dff7](012dff7))
* **Prime Video:** Add `Rename shared permissions` patch ([#5049](#5049)) ([80f1fc6](80f1fc6))
* **Spotify:** Add `Fix Facebook login` patch ([#5023](#5023)) ([34932dc](34932dc))
* **Threads:** Hide Ads ([#5064](#5064)) ([3c4cecb](3c4cecb))
* **YouTube - Enable debugging:** Add settings menu to share debug logs ([#5021](#5021)) ([1ec4a88](1ec4a88))
* **YouTube - Settings:** Add a color picker ([#4981](#4981)) ([1e0e398](1e0e398))
* **YouTube - Swipe controls:** Add separate color settings for the brightness and volume bars ([#5043](#5043)) ([80f50e8](80f50e8))
* **YouTube:** Add `Disable haptic feedback` patch ([#5033](#5033)) ([bbe7974](bbe7974))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(YouTube): Disable haptic feedback while navigating between chapters
4 participants