-
-
Notifications
You must be signed in to change notification settings - Fork 426
feat(GmsCore support): Open vendor specific DontKillMyApp if available #4952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(GmsCore support): Open vendor specific DontKillMyApp if available #4952
Conversation
8c22a94
to
6cbf88e
Compare
How come MicroG is listed as an app there? |
the Including the parameter shows a stripped down page with only end user instructions, and replaces the "your app" with that https://dontkillmyapp.com/sony?app=MicroG
https://dontkillmyapp.com/sony
|
For future reference, the old v1 api has a listing of all manufacturer names the site supports: Such as Nokia that ships devices with a |
In that case the name should be GmsCore or "MicroG GmsCore" |
But the app name on their device is "MicroG". The instructions will be wrong if it shows "MicroG GmsCore" because no such app exists. |
PS: it's DontKillMyApp, not DoNotKillMyApp in the PR title and code |
6cbf88e
to
0a5753c
Compare
# [5.24.0-dev.2](v5.24.0-dev.1...v5.24.0-dev.2) (2025-05-14) ### Features * **GmsCore support:** Open vendor specific DontKillMyApp if available ([#4952](#4952)) ([b89927a](b89927a)) * **YouTube - Hide player components:** Hide related video overlay in fullscreen ([#4938](#4938)) ([ac9be97](ac9be97))
If GmsCore has been granted battery whitelist permission, but it's still not running in the background, then the user needs to follow manufacturer specific steps to allow GmsCore to run.
Normally this opens DontKillMyApp.com but it's full of extra information such as other vendors, a history of the problem per vendor, developer information, and other information that is irrelevant to the end user who just wants instructions how to fix the problem for their device.
Thankfully, DontKillMyApp.com has an api to check if a vendor specific page exists, and a url
app
parameter to show only end user instructions for the app.For example, on Samsung devices the GmsCore dialog now opens:
https://dontkillmyapp.com/samsung?app=MicroG
On Sony devices it opens:
https://dontkillmyapp.com/sony?app=MicroG
And if no manufacturer specific page exists, then it open the general page that includes steps that work for (most) devices:
https://dontkillmyapp.com/general?app=MicroG