Skip to content

feat(GmsCore support): Open vendor specific DontKillMyApp if available #4952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented May 13, 2025

If GmsCore has been granted battery whitelist permission, but it's still not running in the background, then the user needs to follow manufacturer specific steps to allow GmsCore to run.

Normally this opens DontKillMyApp.com but it's full of extra information such as other vendors, a history of the problem per vendor, developer information, and other information that is irrelevant to the end user who just wants instructions how to fix the problem for their device.

Thankfully, DontKillMyApp.com has an api to check if a vendor specific page exists, and a url app parameter to show only end user instructions for the app.

For example, on Samsung devices the GmsCore dialog now opens:
https://dontkillmyapp.com/samsung?app=MicroG

On Sony devices it opens:
https://dontkillmyapp.com/sony?app=MicroG

And if no manufacturer specific page exists, then it open the general page that includes steps that work for (most) devices:
https://dontkillmyapp.com/general?app=MicroG

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(GmsCores support): Open vendor specific DoNotKillMyApp if available fix(GmsCore support): Open vendor specific DoNotKillMyApp if available May 13, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the fix/microg_open_manufacturer_page branch from 8c22a94 to 6cbf88e Compare May 13, 2025 19:55
@oSumAtrIX
Copy link
Member

How come MicroG is listed as an app there?

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented May 13, 2025

the app parameter is any app name.

Including the parameter shows a stripped down page with only end user instructions, and replaces the "your app" with that
specific name:

https://dontkillmyapp.com/sony?app=MicroG

Try to make MicroG not battery optimized in Phone settings > Battery > Three dots in the top right corner > Battery optimisation > Apps > MicroG”

https://dontkillmyapp.com/sony

Try to make your app not battery optimized in Phone settings > Battery > Three dots in the top right corner > Battery optimisation > Apps > your app.”

@LisoUseInAIKyrios
Copy link
Contributor Author

For future reference, the old v1 api has a listing of all manufacturer names the site supports:
https://dontkillmyapp.com/api/v1/output.json

Such as Nokia that ships devices with a Build.MANUFACTURER of either nokia or hmd global
where either manufacturer opens the same page:
https://dontkillmyapp.com/nokia?app=MicroG
https://dontkillmyapp.com/hmd-global?app=MicroG

@oSumAtrIX
Copy link
Member

In that case the name should be GmsCore or "MicroG GmsCore"

@LisoUseInAIKyrios
Copy link
Contributor Author

But the app name on their device is "MicroG".

The instructions will be wrong if it shows "MicroG GmsCore" because no such app exists.

@oSumAtrIX
Copy link
Member

oSumAtrIX commented May 13, 2025

PS: it's DontKillMyApp, not DoNotKillMyApp in the PR title and code

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(GmsCore support): Open vendor specific DoNotKillMyApp if available fix(GmsCore support): Open vendor specific DontKillMyApp if available May 13, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the fix/microg_open_manufacturer_page branch from 6cbf88e to 0a5753c Compare May 13, 2025 20:06
@oSumAtrIX oSumAtrIX changed the title fix(GmsCore support): Open vendor specific DontKillMyApp if available feat(GmsCore support): Open vendor specific DontKillMyApp if available May 13, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit b89927a into ReVanced:dev May 14, 2025
1 check passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix/microg_open_manufacturer_page branch May 14, 2025 07:01
github-actions bot pushed a commit that referenced this pull request May 14, 2025
# [5.24.0-dev.2](v5.24.0-dev.1...v5.24.0-dev.2) (2025-05-14)

### Features

* **GmsCore support:** Open vendor specific DontKillMyApp if available ([#4952](#4952)) ([b89927a](b89927a))
* **YouTube - Hide player components:** Hide related video overlay in fullscreen ([#4938](#4938)) ([ac9be97](ac9be97))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants