Skip to content

fix(YouTube): Simplify litho filtering patch #4910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 5, 2025
Merged

fix(YouTube): Simplify litho filtering patch #4910

merged 4 commits into from
May 5, 2025

Conversation

LisoUseInAIKyrios
Copy link
Contributor

Followup fix for #4904

Simplifies the litho patch, and fixes concurrent thread issue introduced with the last change.

@chsbuffer
Copy link

If neither fingerprint { strings(", identifierProperty=") } nor first get string in the method work consistently, can we give the match the second initialized string type field in the ConversionContext parameterized constructor a try?

@LisoUseInAIKyrios
Copy link
Contributor Author

LisoUseInAIKyrios commented May 5, 2025 •
edited
Loading

The identifier is the second parameter in the constructor, but in 20.12 it's not the second parameter.

The commit I just pushed works for all supported targets. It basically gets the identifier field the same way it did before these fixes.

@chsbuffer
Copy link

chsbuffer commented May 5, 2025 •
edited
Loading

For 19.16.39, 19.17.42, 20.17.41, 20.12.46 , the identifier parameter is consistently the 15th parameter.
image

@LisoUseInAIKyrios
Copy link
Contributor Author

I must have been looking at the wrong field.

I'll try refactoring in a moment.

@chsbuffer
Copy link

image
Based on code in some versions (e.g. 19.16.39-1545731520), a consistent way to identify the field is by looking for the second String type field that is referenced by an iput-object instruction.

@LisoUseInAIKyrios
Copy link
Contributor Author

Hmmm, with the register moves it seems kinda flaky. I think what's here is ok since it's not affected by register moves or constructor parameters changing.

@chsbuffer
Copy link

I agree, what's here is ok.

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit bd53955 into ReVanced:dev May 5, 2025
1 check passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix/litho_filtering_multithreaded branch May 5, 2025 11:25
github-actions bot pushed a commit that referenced this pull request May 5, 2025
@semantic-release-bot
chore: Release v5.23.0-dev.3 [skip ci]
c7a22bb 
# [5.23.0-dev.3](v5.23.0-dev.2...v5.23.0-dev.3) (2025-05-05)

### Bug Fixes

* **YouTube:** Simplify litho filtering patch ([#4910](#4910)) ([bd53955](bd53955))
github-actions bot pushed a commit that referenced this pull request May 10, 2025
@semantic-release-bot
chore: Release v5.23.0 [skip ci]
25e7dc1 
# [5.23.0](v5.22.0...v5.23.0) (2025-05-10)

### Bug Fixes

* Correct incorrect fingerprint ([c3bab89](c3bab89))
* Fix incorrect fingerprints ([#4917](#4917)) ([49ca329](49ca329))
* **Spotify - Unlock Spotify Premium:** Remove pop up premium ads ([#4842](#4842)) ([00aa200](00aa200))
* **YouTube:** Improve litho filtering performance ([#4904](#4904)) ([7b43986](7b43986))
* **YouTube:** Simplify litho filtering patch ([#4910](#4910)) ([bd53955](bd53955))

### Features

* **Lightroom:** Constrain patches to last working version ([efef03b](efef03b))
* **Pandora:** Add `Disable audio ads` and `Unlimited skips` patch ([#4841](#4841)) ([0cf7a4c](0cf7a4c))
* **Prime Video:** Add `Skip ads` patch ([#4824](#4824)) ([bb672c4](bb672c4))
* **Spotify:** Add `Sanitize sharing links` patch ([#4829](#4829)) ([2e3511d](2e3511d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chsbuffer chsbuffer chsbuffer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LisoUseInAIKyrios @chsbuffer