fix(YouTube): Improve litho filtering performance #4904
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LisoUseInAIKyrios Did you used the invoke-virtual (called before return-object) register, to retrieve StringBuilder? |
|
Anyway...this fix can work or not (for this reason, every testing feedback can be helpful), but this is my current SoT with it:
|
|
Both identifier and string builder are public fields on the config object. So no invoke method is needed. For 19.16 I had to add an invoke virtual method on a parameter object to get the config, then access the identifier and builder from the field. |
This was referenced May 3, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 4, 2025
# [5.23.0-dev.2](v5.23.0-dev.1...v5.23.0-dev.2) (2025-05-04) ### Bug Fixes * **YouTube:** Improve litho filtering performance ([#4904](#4904)) ([7b43986](7b43986))
This comment was marked as resolved.
This comment was marked as resolved.
github-actions bot
pushed a commit
that referenced
this pull request
May 10, 2025
# [5.23.0](v5.22.0...v5.23.0) (2025-05-10) ### Bug Fixes * Correct incorrect fingerprint ([c3bab89](c3bab89)) * Fix incorrect fingerprints ([#4917](#4917)) ([49ca329](49ca329)) * **Spotify - Unlock Spotify Premium:** Remove pop up premium ads ([#4842](#4842)) ([00aa200](00aa200)) * **YouTube:** Improve litho filtering performance ([#4904](#4904)) ([7b43986](7b43986)) * **YouTube:** Simplify litho filtering patch ([#4910](#4910)) ([bd53955](bd53955)) ### Features * **Lightroom:** Constrain patches to last working version ([efef03b](efef03b)) * **Pandora:** Add `Disable audio ads` and `Unlimited skips` patch ([#4841](#4841)) ([0cf7a4c](0cf7a4c)) * **Prime Video:** Add `Skip ads` patch ([#4824](#4824)) ([bb672c4](bb672c4)) * **Spotify:** Add `Sanitize sharing links` patch ([#4829](#4829)) ([2e3511d](2e3511d))
litos661
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves litho filtering by allowing YT litho code to behave the same as unpatched.
If a component is filtered, the
nullsentinel value is returned at the same return index as the unpatched method. Previously the null sentinel returned early, which causes class fields and other cached values to never be set.This change appears to improve memory usage on some devices.
Issue and fix was identified by @0xrxL