Skip to content

fix(Spotify - Unlock Spotify Premium): Remove pop up premium ads #4842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
May 6, 2025
Merged

fix(Spotify - Unlock Spotify Premium): Remove pop up premium ads #4842

merged 22 commits into from
May 6, 2025
+136 −42

Conversation

Nuckyz
Copy link
Contributor

@Nuckyz Nuckyz commented Apr 22, 2025 •
edited
Loading

Difficult to test but it should work

@Nuckyz
Copy link
Contributor Author

Nuckyz commented Apr 22, 2025

Already checked and the pendragon requests do not exist in the legacy app.

@Nuckyz
Copy link
Contributor Author

Nuckyz commented Apr 22, 2025

Switched to a different way of removing the pendragon ads by avoiding the request completely.

@Nuckyz Nuckyz changed the title fix(Spotify): Remove pop out premium ads fix(Spotify): Remove pop up premium ads Apr 23, 2025
@LisoUseInAIKyrios
Copy link
Contributor

Is this ready to merge?

@oSumAtrIX oSumAtrIX self-requested a review April 24, 2025 16:27
@Nuckyz
Copy link
Contributor Author

Nuckyz commented Apr 24, 2025

Is this ready to merge?

Should be, but I think oSum wants to review first

@Nuckyz Nuckyz mentioned this pull request Apr 27, 2025
Open
3 tasks
oSumAtrIX
oSumAtrIX approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after the last suggestion

@oSumAtrIX oSumAtrIX changed the title fix(Spotify): Remove pop up premium ads fix(Spotify - Unlock Spotify Premium): Remove pop up premium ads May 5, 2025
Nuckyz and others added 2 commits May 5, 2025 11:13
@Nuckyz
Update UnlockPremiumPatch.kt
d33cac0
@LisoUseInAIKyrios
Merge remote-tracking branch 'upstream/dev' into spotify/pendragon-ads
a6e936f 
# Conflicts:
#	patches/src/main/kotlin/app/revanced/patches/spotify/misc/UnlockPremiumPatch.kt
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 00aa200 into ReVanced:dev May 6, 2025
1 check passed
github-actions bot pushed a commit that referenced this pull request May 6, 2025
@semantic-release-bot
chore: Release v5.23.0-dev.5 [skip ci]
bc2575b 
# [5.23.0-dev.5](v5.23.0-dev.4...v5.23.0-dev.5) (2025-05-06)

### Bug Fixes

* **Spotify - Unlock Spotify Premium:** Remove pop up premium ads ([#4842](#4842)) ([00aa200](00aa200))

### Features

* **Pandora:** Add `Disable audio ads` and `Unlimited skips` patch ([#4841](#4841)) ([0cf7a4c](0cf7a4c))
* **Prime Video:** Add `Skip ads` patch ([#4824](#4824)) ([bb672c4](bb672c4))
@cyberboh cyberboh mentioned this pull request May 6, 2025
Closed
3 tasks
@Nuckyz Nuckyz deleted the spotify/pendragon-ads branch May 6, 2025 13:09
@JingMatrix
Copy link

Hi, I don't see how this patch helps to hide ADs.
I logged the FetchMessageRequest instances, and here are the results:

FetchMessageRequest(locale=fr_FR, triggerType=URI, triggerPatterns=[spotify:home], entityUri=spotify:home, opportunityId=ceb5de9c-883b-42a4-a692-0edef88dfd56, purchaseAllowed=true)
FetchMessageRequest(locale=fr_FR, triggerType=URI, triggerPatterns=[spotify:find], entityUri=spotify:find, opportunityId=8e9676ed-441e-44be-a87e-91d58e44b16e, purchaseAllowed=true)
FetchMessageRequest(locale=fr_FR, triggerType=URI, triggerPatterns=[spotify:album:?], entityUri=spotify:album:1XucHxMvhU9rtd8yXkjNG5, opportunityId=707b4717-4b42-4f01-bab1-a99bf6bb3222, purchaseAllowed=true)

Could you please explain why it is related to pop-up ADs?

@Nuckyz
Copy link
Contributor Author

Nuckyz commented May 10, 2025

Hi, I don't see how this patch helps to hide ADs. I logged the FetchMessageRequest instances, and here are the results:

FetchMessageRequest(locale=fr_FR, triggerType=URI, triggerPatterns=[spotify:home], entityUri=spotify:home, opportunityId=ceb5de9c-883b-42a4-a692-0edef88dfd56, purchaseAllowed=true)
FetchMessageRequest(locale=fr_FR, triggerType=URI, triggerPatterns=[spotify:find], entityUri=spotify:find, opportunityId=8e9676ed-441e-44be-a87e-91d58e44b16e, purchaseAllowed=true)
FetchMessageRequest(locale=fr_FR, triggerType=URI, triggerPatterns=[spotify:album:?], entityUri=spotify:album:1XucHxMvhU9rtd8yXkjNG5, opportunityId=707b4717-4b42-4f01-bab1-a99bf6bb3222, purchaseAllowed=true)

Could you please explain why it is related to pop-up ADs?

Click on the premium button in the choose media quality section in settings and you will see. This request returns what is used to create the pop up ads, but not all the time so sometimes it may seem irrelevant.

@Nuckyz
Copy link
Contributor Author

Nuckyz commented May 10, 2025

It's also a matter of testing. Haven't had any more ads since patching this.

@Nuckyz
Copy link
Contributor Author

Nuckyz commented May 10, 2025 •
edited
Loading

Hi, I don't see how this patch helps to hide ADs. I logged the FetchMessageRequest instances, and here are the results:

FetchMessageRequest(locale=fr_FR, triggerType=URI, triggerPatterns=[spotify:home], entityUri=spotify:home, opportunityId=ceb5de9c-883b-42a4-a692-0edef88dfd56, purchaseAllowed=true)
FetchMessageRequest(locale=fr_FR, triggerType=URI, triggerPatterns=[spotify:find], entityUri=spotify:find, opportunityId=8e9676ed-441e-44be-a87e-91d58e44b16e, purchaseAllowed=true)
FetchMessageRequest(locale=fr_FR, triggerType=URI, triggerPatterns=[spotify:album:?], entityUri=spotify:album:1XucHxMvhU9rtd8yXkjNG5, opportunityId=707b4717-4b42-4f01-bab1-a99bf6bb3222, purchaseAllowed=true)

Could you please explain why it is related to pop-up ADs?

Also those are just the requests, you need to look at the responses. They return data used to construct html views when a pop up is to be shown.

github-actions bot pushed a commit that referenced this pull request May 10, 2025
@semantic-release-bot
chore: Release v5.23.0 [skip ci]
25e7dc1 
# [5.23.0](v5.22.0...v5.23.0) (2025-05-10)

### Bug Fixes

* Correct incorrect fingerprint ([c3bab89](c3bab89))
* Fix incorrect fingerprints ([#4917](#4917)) ([49ca329](49ca329))
* **Spotify - Unlock Spotify Premium:** Remove pop up premium ads ([#4842](#4842)) ([00aa200](00aa200))
* **YouTube:** Improve litho filtering performance ([#4904](#4904)) ([7b43986](7b43986))
* **YouTube:** Simplify litho filtering patch ([#4910](#4910)) ([bd53955](bd53955))

### Features

* **Lightroom:** Constrain patches to last working version ([efef03b](efef03b))
* **Pandora:** Add `Disable audio ads` and `Unlimited skips` patch ([#4841](#4841)) ([0cf7a4c](0cf7a4c))
* **Prime Video:** Add `Skip ads` patch ([#4824](#4824)) ([bb672c4](bb672c4))
* **Spotify:** Add `Sanitize sharing links` patch ([#4829](#4829)) ([2e3511d](2e3511d))
@JingMatrix
Copy link

Thank you for giving the example. I found that to disable the ADs, it suffcies to change the purchaseAllowed parameter

FetchMessageRequest(locale=fr_FR, triggerType=CLIENT_EVENT, triggerPatterns=[upsell:streaming-quality:v1], entityUri=upsell:streaming-quality:v1, opportunityId=856dfba1-8e5a-4cdd-8863-71ed4c8ca50a, purchaseAllowed=false)

And do you know how to triger ADs with fetchMessageListRequest?

JingMatrix added a commit to JingMatrix/ChromeXt that referenced this pull request May 10, 2025
@JingMatrix
Remove pendragon upsell of premium
b27ce27 
Methods discovered in ReVanced/revanced-patches#4842.
@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue May 14, 2025 that may be closed by this pull request
bug(Spotify): Upgrade to premium banner ad #4830
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisoUseInAIKyrios LisoUseInAIKyrios LisoUseInAIKyrios approved these changes

@oSumAtrIX oSumAtrIX oSumAtrIX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Spotify): Upgrade to premium banner ad
4 participants
@Nuckyz @LisoUseInAIKyrios @JingMatrix @oSumAtrIX