Skip to content

feat(Spotify): Add limited support for version 8.6.98.900 (last version that supports Kenwood and Pioneer car stereos) #4750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Apr 11, 2025
Merged

feat(Spotify): Add limited support for version 8.6.98.900 (last version that supports Kenwood and Pioneer car stereos) #4750

merged 13 commits into from
Apr 11, 2025

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Apr 7, 2025 •
edited
Loading

Adds limited support for 8.6.98.900 (the last app target that works correctly with Kenwood and Pioneer car head units)

Functionality that may or may not work:

  • Hiding home ads
  • Hiding 'Spotify Premium' context menu upsell
  • Asking to play a specific song with Google assistant (artist station is played instead)
  • Custom theme patch may not override all component colors

The only testing performed was opening the app and playing a few songs.

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Apr 7, 2025 that may be closed by this pull request
feat(Spotify): Support version 8.6.98.900 #4746
Closed
3 tasks
@Nuckyz

This comment was marked as resolved.

Sign in to view
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the feat/spotify_legacy_target branch from b2385af to e018c33 Compare April 7, 2025 15:06
@LisoUseInAIKyrios

This comment was marked as resolved.

Sign in to view
@Nuckyz

This comment was marked as resolved.

Sign in to view
@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the feat/spotify_legacy_target branch from c94406f to abdaff9 Compare April 7, 2025 23:12
@orzcode
Copy link

orzcode commented Apr 8, 2025

This is amazing work. Huge kudos to you and those involved.

I think it's fair to not bother with custom themes. It's not worth the extra work.

However I do think there is a good case for attempting to preserve the other functionality:

  • Hiding home ads
  • Hiding 'Spotify Premium' upsell experiments

Reasoning for this is that this specific version will be used basically indefinitely, by a large number of people around the world with Kenwood or Pioneer head units, for years to come. It's a one-and-done thing, I would imagine.

It's not crucial though, I'm just outlining my reasoning. Thank you so much for your work

@LisoUseInAIKyrios
Copy link
Contributor Author

However I do think there is a good case for attempting to preserve the other functionality:

  • Hiding home ads
  • Hiding 'Spotify Premium' upsell experiments

I looked but could not find code similar to what is patched in the latest app release. It's possible that neither of these are present in this specific old release.

The number of users who have these old stereos and want to use ReVanced may number in the hundreds (or even less). Unless someone can confirm these ads are present, and more importantly someone wants to spend their personal time to figure out a solution, then it's not worth the effort. It's already a future maintenance cost just adding this limited support.

@orzcode
Copy link

orzcode commented Apr 8, 2025

However I do think there is a good case for attempting to preserve the other functionality:

  • Hiding home ads
  • Hiding 'Spotify Premium' upsell experiments

I looked but could not find code similar to what is patched in the latest app release. It's possible that neither of these are present in this specific old release.

The number of users who have these old stereos and want to use ReVanced may number in the hundreds (or even less). Unless someone can confirm these ads are present, and more importantly someone wants to spend their personal time to figure out a solution, then it's not worth the effort. It's already a future maintenance cost just adding this limited support.

Very good point. Thank you for the hard work you did to achieve this.

@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the feat/spotify_legacy_target branch from abdaff9 to 8baf5ae Compare April 8, 2025 10:44
@cyberboh

This comment was marked as off-topic.

Sign in to view
@LisoUseInAIKyrios

This comment was marked as off-topic.

Sign in to view
Nuckyz
Nuckyz suggested changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@Nuckyz Nuckyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should research what is the lowest version which can be patched by this.

@LisoUseInAIKyrios
Copy link
Contributor Author

We should research what is the lowest version which can be patched by this.

Is there any differences with older versions? If there's no difference compared to 8.6.98.900 then there isn't any real reason to use anything older.

@Nuckyz
Copy link
Contributor

Nuckyz commented Apr 8, 2025

We should research what is the lowest version which can be patched by this.

Is there any differences with older versions? If there's no difference compared to 8.6.98.900 then there isn't any real reason to use anything older.

Mainly for documentation, honestly

@Nuckyz
Copy link
Contributor

Nuckyz commented Apr 8, 2025

@LisoUseInAIKyrios I propose the following patch to make it simpler to detect whether we are in the legacy or new app.

diff.patch

Nuckyz
Nuckyz approved these changes Apr 9, 2025
View reviewed changes
Copy link
Contributor

@Nuckyz Nuckyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@0xrxL
Copy link

0xrxL commented Apr 9, 2025

@Nuckyz There's a way to unlock the shazam login to spotify?

@Nuckyz
Copy link
Contributor

Nuckyz commented Apr 9, 2025

@Nuckyz There's a way to unlock the shazam login to spotify?

How does one login with shazam?

@oSumAtrIX
Copy link
Member

It's not related to this PR. Shazam doesn't require Spotify Premium.

@ReVanced ReVanced deleted a comment from revanced-bot Apr 9, 2025
@0xrxL
Copy link

0xrxL commented Apr 9, 2025 •
edited
Loading

@Nuckyz There's a way to unlock the shazam login to spotify?

How does one login with shazam?

Shazam -> Settings -> Connect with Spotify

Shazam doesn't require Spotify Premium.

It doesn't work with modded apk.

@LisoUseInAIKyrios LisoUseInAIKyrios removed the request for review from oSumAtrIX April 10, 2025 13:40
@wotikama
Copy link

Im interested in applying this patch, but I dont know how to. Can you help?

@LisoUseInAIKyrios
Copy link
Contributor Author

Need to build from source then patch with CLI tools.

Or wait a day or two until after this is merged to dev, then patch using CLI tools and the latest dev release.

@wotikama
Copy link

Need to build from source then patch with CLI tools.

Or wait a day or two until after this is merged to dev, then patch using CLI tools and the latest dev release.
🙏 done for 8.8.0.347 ❤️

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(Spotify - Unlock premium): Add limited support for legacy app target 8.6.98.900 fix(Spotify): Add limited support for legacy app target 8.6.98.900 Apr 10, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(Spotify): Add limited support for legacy app target 8.6.98.900 feat(Spotify): Add limited support for legacy app target 8.6.98.900 Apr 10, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(Spotify): Add limited support for legacy app target 8.6.98.900 feat(Spotify): Add limited support for legacy app target 8.6.98.900 Apr 10, 2025
@oSumAtrIX oSumAtrIX changed the title feat(Spotify): Add limited support for legacy app target 8.6.98.900 feat(Spotify): Add limited support for version 8.6.98.900 (last version that supports Kenwood and Pioneer car stereos) Apr 11, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios merged commit a3fde87 into ReVanced:dev Apr 11, 2025
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the feat/spotify_legacy_target branch April 11, 2025 19:30
github-actions bot pushed a commit that referenced this pull request Apr 11, 2025
@semantic-release-bot
chore: Release v5.19.0-dev.13 [skip ci]
e5ffd2c 
# [5.19.0-dev.13](v5.19.0-dev.12...v5.19.0-dev.13) (2025-04-11)

### Features

* **Spotify:** Add limited support for version `8.6.98.900` (last version that supports Kenwood and Pioneer car stereos) ([#4750](#4750)) ([a3fde87](a3fde87))
github-actions bot pushed a commit that referenced this pull request Apr 12, 2025
@semantic-release-bot
chore: Release v5.19.0 [skip ci]
4b84742 
# [5.19.0](v5.18.0...v5.19.0) (2025-04-12)

### Bug Fixes

* **Google Photos - Restore hidden 'Back up while charging' toggle:** Constrain to last working app target ([#4761](#4761)) ([152bb7c](152bb7c))
* **Google Photos:** Remove obsolete non functional patch `Restore hidden 'Back up while charging' toggle` ([#4764](#4764)) ([56e48f4](56e48f4))
* **Spotify - Custom theme:** Override more color resources ([#4690](#4690)) ([d7a7a0b](d7a7a0b))
* **Spotify - Unlock Spotify Premium:** Remove restrictions for Google voice assistant ([#4702](#4702)) ([106202f](106202f))
* **Spotify:** Remove ads sections from home ([#4722](#4722)) ([0b9a5e7](0b9a5e7))
* **Twitter - Hide recommended users:** Make hiding work again by filtering for new entryId prefix ([#4456](#4456)) ([ff846b0](ff846b0))
* **YouTube - Hide layout components:** Do not hide video description music/game links if hide horizontal shelves is enabled ([3864f35](3864f35))
* **YouTube - Hide player flyout menu items:** Show more detailed summary text for 'Hide Audio track' if using Android spoof client ([#4756](#4756)) ([b67bbb2](b67bbb2))
* **YouTube - Remove background playback restrictions:** Do not show media controls when playing Shorts from the feed ([2ed675c](2ed675c))
* **YouTube - Return YouTube Dislike:** Correctly update label after disliking a Short with 20.07 ([0bb3e32](0bb3e32))
* **YouTube - Return YouTube Dislike:** Fix inconsistent label after disliking a Short ([ea92a2e](ea92a2e))
* **YouTube - Seekbar:** Correctly hide the feed seekbar with target 20.07 ([ddc6e4c](ddc6e4c))
* **YouTube:** Combine multiple seekbar patches into a single patch ([#4705](#4705)) ([503b7eb](503b7eb))

### Features

* **Angulus:** Add `Hide ads` patch ([#4604](#4604)) ([87c86b5](87c86b5))
* **Messenger:** Add `Remove Meta AI tab` patch ([#4726](#4726)) ([e3fad97](e3fad97))
* **Photomath:** Support latest version ([#4672](#4672)) ([8e16483](8e16483))
* **Proton Mail:** Add `Remove 'Sent from' signature` patch ([#4514](#4514)) ([34c14c9](34c14c9))
* **Spotify:** Add `Check environment` patch ([#4765](#4765)) ([6d7101c](6d7101c))
* **Spotify:** Add limited support for version `8.6.98.900` (last version that supports Kenwood and Pioneer car stereos) ([#4750](#4750)) ([a3fde87](a3fde87))
* **Strava - Disable subscription suggestions:** Make compatible with latest version ([#4739](#4739)) ([649a2c0](649a2c0))
* **YouTube - Settings:** Add icons to the ReVanced settings ([#4496](#4496)) ([d0c85f0](d0c85f0))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyberboh cyberboh cyberboh left review comments

@oSumAtrIX oSumAtrIX oSumAtrIX approved these changes

@Nuckyz Nuckyz Nuckyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(Spotify): Support version 8.6.98.900
7 participants
@LisoUseInAIKyrios @Nuckyz @orzcode @cyberboh @0xrxL @oSumAtrIX @wotikama