feat(YouTube - Settings): Add icons to the ReVanced settings #4496

MarcaDian · 2025-02-23T07:59:30Z

Adds icons to the ReVanced settings menu.

Icons can be turned off in General > Show ReVanced settings icons

After

LisoUseInAIKyrios · 2025-02-23T08:52:30Z

The YouTube brand guidelines does not mention Shorts or the Shorts logo, so it's unclear if permission is needed to use a Shorts icon.

https://www.youtube.com/howyoutubeworks/resources/brand-resources

# Conflicts: # patches/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsPatch.kt # patches/src/main/resources/settings/drawable/revanced_settings_screen_00_about.xml # patches/src/main/resources/settings/drawable/revanced_settings_screen_01_ads.xml # patches/src/main/resources/settings/drawable/revanced_settings_screen_02_alt_thumbnails.xml # patches/src/main/resources/settings/drawable/revanced_settings_screen_03_feed.xml # patches/src/main/resources/settings/drawable/revanced_settings_screen_04_general.xml # patches/src/main/resources/settings/drawable/revanced_settings_screen_05_player.xml # patches/src/main/resources/settings/drawable/revanced_settings_screen_06_shorts.xml # patches/src/main/resources/settings/drawable/revanced_settings_screen_07_seekbar.xml # patches/src/main/resources/settings/drawable/revanced_settings_screen_08_swipe_controls.xml # patches/src/main/resources/settings/drawable/revanced_settings_screen_11_misc.xml # patches/src/main/resources/settings/drawable/revanced_settings_screen_12_video.xml

MarcaDian · 2025-02-23T09:02:58Z

I took the Shorts icon from some site and edited it to size. It is not in the Google icon repository. In fact, it is custom icon.

LisoUseInAIKyrios · 2025-02-23T09:07:15Z

Their brand guidelines apply to custom graphics as well. The question is if the Shorts logo needs permission to use.

MarcaDian · 2025-02-23T09:12:39Z

I think it's better to add Copyright than to decide if it is necessary or not.

LisoUseInAIKyrios · 2025-02-23T09:28:10Z

https://en.m.wikipedia.org/wiki/File:Youtube_shorts_icon.svg

Wikipedia lists the vector icon file as public domain, but with a caution that it might be trademarked.

Searching the USPTO website shows that "YouTube Shorts" is trademarked:
https://tsdr.uspto.gov/#caseNumber=90980684&caseSearchType=US_APPLICATION&caseType=DEFAULT&searchType=statusSearch
https://tsdr.uspto.gov/#caseNumber=90313243&caseSearchType=US_APPLICATION&caseType=DEFAULT&searchType=statusSearch

But the trademark does not include a wordmark or logo. For reference the YouTube logo and wordmark is trademarked

So, maybe it's ok to modify and use the public domain vector icon.

kitadai31 · 2025-02-23T10:27:54Z

Can't it depend on the app's native icon resources?
@drawable/yt_outline_youtube_shorts_black_24 and @drawable/yt_outline_youtube_shorts_white_24 exist

LisoUseInAIKyrios · 2025-02-23T11:28:31Z

If that built in icon matches the line width of the other icons (or the other icons can be adjusted to match the built in icon), then using that would be best.

But I think using the icon already here might be ok too

patches/src/main/kotlin/app/revanced/patches/shared/misc/settings/SettingsPatch.kt

MarcaDian · 2025-02-23T15:33:54Z

If necessary, it is also possible to add icons to the submenus, but it seems to me that this goes beyond the design code of the YouTube settings.

Although, for example, hiding buttons for the user would be intuitive as to which button would be hidden.

LisoUseInAIKyrios · 2025-02-23T15:41:01Z

I think icons for only some submenu items but not for other items would look out of place.

The hide action and navigation buttons are the only settings that an icon might help, but I think it's easy to understand what those settings do just from the setting title text.

MarcaDian · 2025-02-23T21:00:38Z

What if change Shorts icon to this. I also made some another variants.
I think it's better not to risk, it's just an icon in settings, and even a branded icon doesn't show the essence of this setting.

LisoUseInAIKyrios · 2025-02-23T21:03:16Z

Looks good, but maybe remove the gear icon. The Shorts settings are less like the video settings and more like the player (which has no gear).

MarcaDian · 2025-02-23T21:04:49Z

but maybe remove the gear icon

Ok, it was a second variant =)

LisoUseInAIKyrios · 2025-02-23T21:05:55Z

https://fonts.google.com/icons?icon.size=24&icon.color=%23e8eaed&icon.query=video&selected=Material+Symbols+Outlined:animated_images:FILL@0;wght@200;GRAD@0;opsz@24&icon.platform=web

The animated images you suggested also looks ok.

MarcaDian · 2025-02-23T22:19:21Z

animated images

~~But it is not available in the GitHub repository...~~ Found

oSumAtrIX · 2025-02-23T22:42:25Z

There's multiple considerations with this PR

The icons don't comply with the design language of YouTube settings
If the design language is broken, then break it as little as possible and use the icon set used in the design language, no custom icons
Trademarked icons like the Shorts icon are probably fine. Maybe there's a way to request rights, similar to how we did it for the YouTube logo on our website and GitHub organization readme. Maybe certain usage doesn't require rights, such as free-use

MarcaDian · 2025-02-24T00:23:02Z

I tried to choose icons more appropriate to the context of the menu item.
But not all necessary icons are in the Google icon library. In any case, if anyone don't like them, can turn them off in the settings.
Perhaps someone has suggestions to change some unsuitable icon.

But IMHO, at the moment, Google has a poor taste in the design code in the YouTube settings, some icons are simply terrible.

Edit: There are no custom icons here.

LisoUseInAIKyrios · 2025-02-24T04:53:23Z

These icons could be default off, so users need to opt in to see them.

# Conflicts: # patches/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsPatch.kt

LisoUseInAIKyrios

Personally I like to use no icons in the settings, but I think this change looks ok and users can turn off the icons if they want.

patches/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsPatch.kt

# [5.19.0-dev.2](v5.19.0-dev.1...v5.19.0-dev.2) (2025-04-02) ### Features * **YouTube - Settings:** Add icons to the ReVanced settings ([#4496](#4496)) ([d0c85f0](d0c85f0))

# [5.19.0](v5.18.0...v5.19.0) (2025-04-12) ### Bug Fixes * **Google Photos - Restore hidden 'Back up while charging' toggle:** Constrain to last working app target ([#4761](#4761)) ([152bb7c](152bb7c)) * **Google Photos:** Remove obsolete non functional patch `Restore hidden 'Back up while charging' toggle` ([#4764](#4764)) ([56e48f4](56e48f4)) * **Spotify - Custom theme:** Override more color resources ([#4690](#4690)) ([d7a7a0b](d7a7a0b)) * **Spotify - Unlock Spotify Premium:** Remove restrictions for Google voice assistant ([#4702](#4702)) ([106202f](106202f)) * **Spotify:** Remove ads sections from home ([#4722](#4722)) ([0b9a5e7](0b9a5e7)) * **Twitter - Hide recommended users:** Make hiding work again by filtering for new entryId prefix ([#4456](#4456)) ([ff846b0](ff846b0)) * **YouTube - Hide layout components:** Do not hide video description music/game links if hide horizontal shelves is enabled ([3864f35](3864f35)) * **YouTube - Hide player flyout menu items:** Show more detailed summary text for 'Hide Audio track' if using Android spoof client ([#4756](#4756)) ([b67bbb2](b67bbb2)) * **YouTube - Remove background playback restrictions:** Do not show media controls when playing Shorts from the feed ([2ed675c](2ed675c)) * **YouTube - Return YouTube Dislike:** Correctly update label after disliking a Short with 20.07 ([0bb3e32](0bb3e32)) * **YouTube - Return YouTube Dislike:** Fix inconsistent label after disliking a Short ([ea92a2e](ea92a2e)) * **YouTube - Seekbar:** Correctly hide the feed seekbar with target 20.07 ([ddc6e4c](ddc6e4c)) * **YouTube:** Combine multiple seekbar patches into a single patch ([#4705](#4705)) ([503b7eb](503b7eb)) ### Features * **Angulus:** Add `Hide ads` patch ([#4604](#4604)) ([87c86b5](87c86b5)) * **Messenger:** Add `Remove Meta AI tab` patch ([#4726](#4726)) ([e3fad97](e3fad97)) * **Photomath:** Support latest version ([#4672](#4672)) ([8e16483](8e16483)) * **Proton Mail:** Add `Remove 'Sent from' signature` patch ([#4514](#4514)) ([34c14c9](34c14c9)) * **Spotify:** Add `Check environment` patch ([#4765](#4765)) ([6d7101c](6d7101c)) * **Spotify:** Add limited support for version `8.6.98.900` (last version that supports Kenwood and Pioneer car stereos) ([#4750](#4750)) ([a3fde87](a3fde87)) * **Strava - Disable subscription suggestions:** Make compatible with latest version ([#4739](#4739)) ([649a2c0](649a2c0)) * **YouTube - Settings:** Add icons to the ReVanced settings ([#4496](#4496)) ([d0c85f0](d0c85f0))

MarcaDian added 2 commits February 22, 2025 19:45

feat(YouTube - Settings): Add icons to the ReVanced settings

d015101

feat(YouTube - Settings): Add icons to the ReVanced settings

0d01e6e

add copyright to shorts icon

3a8fb1b

LisoUseInAIKyrios reviewed Feb 23, 2025

View reviewed changes

patches/src/main/kotlin/app/revanced/patches/shared/misc/settings/SettingsPatch.kt Outdated Show resolved Hide resolved

LisoUseInAIKyrios force-pushed the settings_icons branch from 03d0585 to 35bec9e Compare February 23, 2025 14:47

fix: Add setting to enable/disable settings icons

d1a4577

LisoUseInAIKyrios force-pushed the settings_icons branch from 35bec9e to d1a4577 Compare February 23, 2025 14:49

LisoUseInAIKyrios marked this pull request as ready for review February 23, 2025 14:50

Alignment of some icons and comments

fba8ece

MarcaDian and others added 3 commits February 24, 2025 10:42

Alignment icons

10f8fc0

Merge remote-tracking branch 'revanced/dev' into settings_icons

f021abf

fix: Fix icons in subgroups

c4feaaa

Merge remote-tracking branch 'upstream/dev' into settings_icons

fa658d5

# Conflicts: # patches/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsPatch.kt

LisoUseInAIKyrios requested a review from oSumAtrIX March 7, 2025 11:22

LisoUseInAIKyrios approved these changes Mar 7, 2025

View reviewed changes

MarcaDian added 2 commits March 19, 2025 22:20

Merge remote-tracking branch 'upstream/dev' into settings_icons

7b2c3ba

change Ads, DeArrow, Player, Swipe icons

f0200ff

LisoUseInAIKyrios removed the request for review from oSumAtrIX April 1, 2025 22:01

LisoUseInAIKyrios reviewed Apr 1, 2025

View reviewed changes

patches/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsPatch.kt Outdated Show resolved Hide resolved

LisoUseInAIKyrios reviewed Apr 1, 2025

View reviewed changes

patches/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsPatch.kt Outdated Show resolved Hide resolved

LisoUseInAIKyrios added 2 commits April 2, 2025 11:33

fix: Add patch name to icon resources

12066f8

fix: Allow turning off icons with old app targets

8450397

LisoUseInAIKyrios merged commit d0c85f0 into ReVanced:dev Apr 2, 2025
1 check passed

MarcaDian deleted the settings_icons branch April 2, 2025 16:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(YouTube - Settings): Add icons to the ReVanced settings #4496

feat(YouTube - Settings): Add icons to the ReVanced settings #4496

MarcaDian commented Feb 23, 2025 •

edited by LisoUseInAIKyrios

Loading

LisoUseInAIKyrios commented Feb 23, 2025

MarcaDian commented Feb 23, 2025

LisoUseInAIKyrios commented Feb 23, 2025

MarcaDian commented Feb 23, 2025

LisoUseInAIKyrios commented Feb 23, 2025 •

edited

Loading

kitadai31 commented Feb 23, 2025

LisoUseInAIKyrios commented Feb 23, 2025

MarcaDian commented Feb 23, 2025

LisoUseInAIKyrios commented Feb 23, 2025

MarcaDian commented Feb 23, 2025 •

edited

Loading

LisoUseInAIKyrios commented Feb 23, 2025

MarcaDian commented Feb 23, 2025

LisoUseInAIKyrios commented Feb 23, 2025

MarcaDian commented Feb 23, 2025 •

edited

Loading

oSumAtrIX commented Feb 23, 2025

MarcaDian commented Feb 24, 2025 •

edited

Loading

LisoUseInAIKyrios commented Feb 24, 2025

LisoUseInAIKyrios left a comment

feat(YouTube - Settings): Add icons to the ReVanced settings #4496

feat(YouTube - Settings): Add icons to the ReVanced settings #4496

Conversation

MarcaDian commented Feb 23, 2025 • edited by LisoUseInAIKyrios Loading

After

LisoUseInAIKyrios commented Feb 23, 2025

MarcaDian commented Feb 23, 2025

LisoUseInAIKyrios commented Feb 23, 2025

MarcaDian commented Feb 23, 2025

LisoUseInAIKyrios commented Feb 23, 2025 • edited Loading

kitadai31 commented Feb 23, 2025

LisoUseInAIKyrios commented Feb 23, 2025

MarcaDian commented Feb 23, 2025

LisoUseInAIKyrios commented Feb 23, 2025

MarcaDian commented Feb 23, 2025 • edited Loading

LisoUseInAIKyrios commented Feb 23, 2025

MarcaDian commented Feb 23, 2025

LisoUseInAIKyrios commented Feb 23, 2025

MarcaDian commented Feb 23, 2025 • edited Loading

oSumAtrIX commented Feb 23, 2025

MarcaDian commented Feb 24, 2025 • edited Loading

LisoUseInAIKyrios commented Feb 24, 2025

LisoUseInAIKyrios left a comment

Choose a reason for hiding this comment

MarcaDian commented Feb 23, 2025 •

edited by LisoUseInAIKyrios

Loading

LisoUseInAIKyrios commented Feb 23, 2025 •

edited

Loading

MarcaDian commented Feb 23, 2025 •

edited

Loading

MarcaDian commented Feb 23, 2025 •

edited

Loading

MarcaDian commented Feb 24, 2025 •

edited

Loading