Skip to content

ts101 gets stuck in boost mode when lock is on #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ouya-woelders opened this issue Apr 1, 2025 · 2 comments
Open

ts101 gets stuck in boost mode when lock is on #2115

ouya-woelders opened this issue Apr 1, 2025 · 2 comments
Assignees

Comments

@ouya-woelders
Copy link

ouya-woelders commented Apr 1, 2025

Describe the bug
with the lock mode set to B, when soldering with lock on, the boost mode stays on even after i release the button.

To Reproduce
Steps to reproduce the behavior:

  1. set lock mode to B
  2. exit the settings
  3. press the first button to turn heating on
  4. hold both buttons to lock the buttons
  5. hold first button to activate boost
  6. release first button
  7. boost mode stays on

Expected behavior
boost mode switches off when i release the button (works on my squire soldering iron)

Details of your device:
TS101
V2.23E.DD4A5500
xiaomi 100w laptop charger (problem is not charger related, i use random chargers. this is just one of them i use)

Additional context

@dinwiggy
Copy link

dinwiggy commented Apr 28, 2025

I'm seeing the same on my Pinecil V2. Issue is not present in 2.22. Issue is present in 2.23rc1, 2.23rc3, and 2.23rc4. All builds tested were from https://github.com/Ralim/IronOS/releases

@dinwiggy
Copy link

dinwiggy commented Apr 28, 2025

It looks like this was lost in the refactor:

v2.22...v2.23-rc4#diff-8c50a175baa140c41981bf7da2a97e85d5ac6b25a88b9ee3c2b89fe055ae7e16L40

https://github.com/Ralim/IronOS/blob/v2.22/source/Core/Threads/OperatingModes/Soldering.cpp#L40

v2.22...v2.23-rc4#diff-9e19aca0dc4c0156c58464c504e2c526c6ea2e85155efd23c5876fd2f456c36fR35

https://github.com/Ralim/IronOS/blob/v2.23-rc4/source/Core/Threads/UI/logic/Soldering.cpp#L35

Adding that logic back in fixed it for me:

Image

This is the only code I've ever looked at in this repo (got my Pinecil last week and noticed this behavior while trying out settings), so I don't feel I'm familiar enough to make a PR at the moment. Hopefully this will help someone with an implementation 😃.

Edit: Diff links don't seem to be working well, so I added links to each version in the source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants