Skip to content

JOSS review : package version for dependencies? #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kanishkan91 opened this issue Jun 4, 2023 · 3 comments
Closed

JOSS review : package version for dependencies? #8

kanishkan91 opened this issue Jun 4, 2023 · 3 comments

Comments

@kanishkan91
Copy link

The dependencies listed here - https://github.com/EpiVec/TDLM/blob/master/DESCRIPTION, don't have an associated pacakge number. Can the author specify what those are? I suspect this is pushing the installation time up significantly since the development version seems to install the latest of every package.

openjournals/joss-reviews#5434

@maximelenormand
Copy link
Member

I followed the CRAN recommendation by not specifying exact versions and not specifying unnecessarily conservative and inconvenient minimal versions. I will try to go through the imports one by one to identify a relevant and not too conservative minimal version.

@maximelenormand
Copy link
Member

I added a minimal version requirement for every dependency in DESCRIPTION.

@kanishkan91
Copy link
Author

Thanks. Closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants