Skip to content

Commit f53fc72

Browse files
NguyenNhuDiNguyenNhuDi
andauthored
[rocPRIM] Disable int tests in test_lookback_reproducibility.cpp (#725)
* updated changelog to include known issue * disabled int test * updated changelog to contain more info * disable int test for navi3x only * fixed linker error * removed comments --------- Co-authored-by: NguyenNhuDi <[email protected]>
1 parent ce086f1 commit f53fc72

File tree

2 files changed

+20
-6
lines changed

2 files changed

+20
-6
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,10 @@ The following is the complete list of affected functions and how their default a
6565
* `rocprim::warp_size()`
6666
* `ROCPRIM_WAVEFRONT_SIZE`
6767

68+
### Known issues
69+
* When using `rocprim::deterministic_inclusive_scan_by_key` and `rocprim::deterministic_exclusive_scan_by_key` the intermediate values can change order on Navi3x
70+
* However if a commutative scan operator is used then the final scan value (output array) will still always be consistent between runs
71+
6872
## rocPRIM 3.4.0 for ROCm 6.4.0
6973

7074
### Added

test/rocprim/test_lookback_reproducibility.cpp

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -82,12 +82,14 @@ struct RocprimLookbackReproducibilityTests : public testing::Test
8282
const bool debug_synchronous = false;
8383
};
8484

85-
using Suite = testing::Types<TestParams<int>, // Sanity check
86-
TestParams<rocprim::bfloat16>,
87-
TestParams<rocprim::half>,
88-
TestParams<float>,
89-
TestParams<double>,
90-
TestParams<common::custom_type<double, double, true>>>;
85+
using Suite = testing::Types<
86+
TestParams<int>,
87+
TestParams<rocprim::bfloat16>,
88+
TestParams<rocprim::half>,
89+
TestParams<float>,
90+
TestParams<double>,
91+
TestParams<common::custom_type<double, double, true>>
92+
>;
9193

9294
TYPED_TEST_SUITE(RocprimLookbackReproducibilityTests, Suite);
9395

@@ -219,6 +221,14 @@ TYPED_TEST(RocprimLookbackReproducibilityTests, ScanByKey)
219221
using compare_op_type = rocprim::equal_to<K>;
220222
using Config = rocprim::default_config;
221223

224+
hipDeviceProp_t attributes;
225+
HIP_CHECK(hipGetDeviceProperties(&attributes, 0));
226+
227+
// Disable int test case for Navi3X because of known issue
228+
if (std::is_same_v<V, int> && attributes.major == 11){
229+
GTEST_SKIP();
230+
}
231+
222232
const size_t min_segment_length = 1000;
223233
const size_t max_segment_length = 10000;
224234

0 commit comments

Comments
 (0)