Skip to content

Commit d60a1fb

Browse files
committed
Added extra command line option to turn off rccl for causal tests
1 parent 93b2749 commit d60a1fb

File tree

2 files changed

+17
-2
lines changed

2 files changed

+17
-2
lines changed

source/bin/omnitrace-causal/impl.cpp

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -607,6 +607,11 @@ parse_args(int argc, char** argv, std::vector<char*>& _env,
607607
.action([&](parser_t& p) {
608608
update_env(_env, "OMNITRACE_CAUSAL_DURATION", p.get<double>("duration"));
609609
});
610+
611+
parser
612+
.add_argument({ "--nrccl" },
613+
"Don't set Use_RCCLP environment variable to true.")
614+
.max_count(1);
610615

611616
int64_t _niterations = 1;
612617
auto _virtual_speedups = std::vector<std::string>{};
@@ -828,7 +833,17 @@ parse_args(int argc, char** argv, std::vector<char*>& _env,
828833
#endif
829834

830835
#if defined(OMNITRACE_USE_RCCL) && OMNITRACE_USE_RCCL > 0
831-
add_default_env(_env, "OMNITRACE_USE_RCCLP", true);
836+
bool add_to_env = true;
837+
for(int i = 0; i < argc; ++i)
838+
{
839+
if(std::string_view{ argv[i] } == "--nrccl")
840+
{
841+
add_to_env = false;
842+
}
843+
}
844+
if (add_to_env){
845+
add_default_env(_env, "OMNITRACE_USE_RCCLP", true);
846+
}
832847
#endif
833848
}
834849

tests/omnitrace-testing.cmake

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,7 @@ function(OMNITRACE_ADD_CAUSAL_TEST)
637637

638638
if(TARGET ${TEST_TARGET})
639639
set(COMMAND_PREFIX $<TARGET_FILE:omnitrace-causal> --reset -m ${TEST_CAUSAL_MODE}
640-
${TEST_CAUSAL_ARGS} --)
640+
${TEST_CAUSAL_ARGS} --nrccl --)
641641

642642
if(NOT TEST_SKIP_BASELINE)
643643
add_test(

0 commit comments

Comments
 (0)