DB patches 8.085_update_radacct_ipv6.sql and 8.090_add_radacct_triggers.sql lead to mysql 1136 errors

[gkelle]

I applied patch 8.085_update_radacct_ipv6.sql and patch 8.090_add_radacct_triggers.sql to my database and noticed that I started getting the following error:
sql: ERROR: rlm_sql_mysql: ERROR 1136 (Column count doesn't match value count at row 1): 21S01

This would occur whenever a client would log off of an SSID using RADIUS+PPSK.

The trigger causing the 1136 error looks like this:

     -- Check if acctstoptime has changed from NULL to NOT NULL
    IF OLD.acctstoptime IS NULL AND NEW.acctstoptime IS NOT NULL THEN
        -- Insert the updated row into radacct_history
        INSERT INTO radacct_history
        SELECT * FROM radacct WHERE radacctid = NEW.radacctid;
    END IF;

Comparing the table definition for radacct and raddact_history, I noticed that raddact_history had fewer columns and was missing framedipv6address, framedipv6prefix, framedinterfaceid, and delegatedipv6prefix

To fix this, I updated 8.085_update_radacct_ipv6.sql to also update the radacct_history table with the new columns and keys.

After updating radacct_history, the trigger and history table behavior was corrected.