Skip to content

Commit 401fb5a

Browse files
committed
Increase tick service delay for esp.
1 parent fbf03ec commit 401fb5a

File tree

11 files changed

+25
-25
lines changed

11 files changed

+25
-25
lines changed

benchmark/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ target_compile_options(quicr_benchmark
3333

3434
set_target_properties(quicr_benchmark
3535
PROPERTIES
36-
CXX_STANDARD 17
36+
CXX_STANDARD 20
3737
CXX_STANDARD_REQUIRED YES
3838
CXX_EXTENSIONS ON)
3939

cmd/examples/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ target_compile_options(qclient
1212

1313
set_target_properties(qclient
1414
PROPERTIES
15-
CXX_STANDARD 17
15+
CXX_STANDARD 20
1616
CXX_STANDARD_REQUIRED YES
1717
CXX_EXTENSIONS OFF)
1818

@@ -31,7 +31,7 @@ target_compile_options(qserver
3131

3232
set_target_properties(qserver
3333
PROPERTIES
34-
CXX_STANDARD 17
34+
CXX_STANDARD 20
3535
CXX_STANDARD_REQUIRED YES
3636
CXX_EXTENSIONS ON)
3737

cmd/qperf/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ target_compile_options(qperf
1212

1313
set_target_properties(qperf
1414
PROPERTIES
15-
CXX_STANDARD 17
15+
CXX_STANDARD 20
1616
CXX_STANDARD_REQUIRED YES
1717
CXX_EXTENSIONS OFF)
1818

cmd/qperf2/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ target_compile_options(qperf_pub
1212

1313
set_target_properties(qperf_pub
1414
PROPERTIES
15-
CXX_STANDARD 17
15+
CXX_STANDARD 20
1616
CXX_STANDARD_REQUIRED YES
1717
CXX_EXTENSIONS OFF)
1818

@@ -34,7 +34,7 @@ target_compile_options(qperf_sub
3434

3535
set_target_properties(qperf_sub
3636
PROPERTIES
37-
CXX_STANDARD 17
37+
CXX_STANDARD 20
3838
CXX_STANDARD_REQUIRED YES
3939
CXX_EXTENSIONS OFF)
4040

include/quicr/detail/data_storage.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,13 @@ namespace quicr {
1414
template<class T, std::enable_if_t<std::is_standard_layout_v<T>, bool> = true>
1515
inline Span<const uint8_t> AsBytes(const T& value)
1616
{
17-
return Span{ reinterpret_cast<const std::uint8_t*>(&value), sizeof(T) };
17+
return Span<const uint8_t>{ reinterpret_cast<const std::uint8_t*>(&value), sizeof(T) };
1818
}
1919

2020
template<>
2121
inline Span<const uint8_t> AsBytes<std::string>(const std::string& value)
2222
{
23-
return Span{ reinterpret_cast<const std::uint8_t*>(value.data()), value.size() };
23+
return Span<const uint8_t>{ reinterpret_cast<const std::uint8_t*>(value.data()), value.size() };
2424
}
2525

2626
template<class Allocator = std::allocator<std::uint8_t>>

include/quicr/detail/stream_buffer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ namespace quicr {
204204
void PushLengthBytes(Span<const T> value)
205205
{
206206
std::lock_guard _(rw_lock_);
207-
PushInternal(Span{ UintVar(static_cast<uint64_t>(value.size())) });
207+
PushInternal(Span<const uint8_t>{ UintVar(static_cast<uint64_t>(value.size())) });
208208
PushInternal(std::move(value));
209209
}
210210

include/quicr/detail/tick_service.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ namespace quicr {
122122
std::atomic<bool> stop_{ false };
123123

124124
/// Sleep delay in microseconds
125-
const uint64_t sleep_delay_us_{ 10000 };
125+
const uint64_t sleep_delay_us_{ 30000 };
126126

127127
/// The thread to update ticks on.
128128
std::thread tick_thread_;

include/quicr/track_name.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ namespace quicr {
3737

3838
std::size_t offset = 0;
3939
const auto add_entry = [&](auto&& e) {
40-
const auto& entry = entries_.emplace_back(Span{ bytes_ }.subspan(offset, e.size()));
40+
const auto& entry = entries_.emplace_back(Span<const uint8_t>{ bytes_ }.subspan(offset, e.size()));
4141
hash_.emplace_back(quicr::hash({ entry.begin(), entry.end() }));
4242

4343
offset += e.size();
@@ -61,7 +61,7 @@ namespace quicr {
6161

6262
std::size_t offset = 0;
6363
const auto add_entry = [&](auto&& e) {
64-
const auto& entry = entries_.emplace_back(Span{ bytes_ }.subspan(offset, e.size()));
64+
const auto& entry = entries_.emplace_back(Span<const uint8_t>{ bytes_ }.subspan(offset, e.size()));
6565
hash_.emplace_back(quicr::hash({ entry.begin(), entry.end() }));
6666
offset += e.size();
6767
};
@@ -84,7 +84,7 @@ namespace quicr {
8484
std::size_t offset = 0;
8585
std::size_t i = 0;
8686
for (auto& entry : entries) {
87-
entries_[i] = Span{ bytes_ }.subspan(offset, entry.size());
87+
entries_[i] = Span<const uint8_t>{ bytes_ }.subspan(offset, entry.size());
8888
hash_.emplace_back(quicr::hash(entry));
8989
offset += entry.size();
9090
++i;
@@ -105,7 +105,7 @@ namespace quicr {
105105
std::size_t offset = 0;
106106
std::size_t i = 0;
107107
for (auto& entry : entries) {
108-
entries_[i] = Span{ bytes_ }.subspan(offset, entry.size());
108+
entries_[i] = Span<const uint8_t>{ bytes_ }.subspan(offset, entry.size());
109109
hash_.emplace_back(quicr::hash(entries_[i]));
110110
offset += entry.size();
111111
++i;
@@ -120,7 +120,7 @@ namespace quicr {
120120
std::size_t offset = 0;
121121
std::size_t i = 0;
122122
for (auto& entry : entries_) {
123-
entries_[i++] = Span{ bytes_ }.subspan(offset, entry.size());
123+
entries_[i++] = Span<const uint8_t>{ bytes_ }.subspan(offset, entry.size());
124124
offset += entry.size();
125125
}
126126
}
@@ -135,7 +135,7 @@ namespace quicr {
135135
std::size_t offset = 0;
136136
std::size_t i = 0;
137137
for (auto& entry : entries_) {
138-
entries_[i++] = Span{ bytes_ }.subspan(offset, entry.size());
138+
entries_[i++] = Span<const uint8_t>{ bytes_ }.subspan(offset, entry.size());
139139
offset += entry.size();
140140
}
141141
}
@@ -149,7 +149,7 @@ namespace quicr {
149149
std::size_t offset = 0;
150150
std::size_t i = 0;
151151
for (auto& entry : entries_) {
152-
entries_[i++] = Span{ bytes_ }.subspan(offset, entry.size());
152+
entries_[i++] = Span<const uint8_t>{ bytes_ }.subspan(offset, entry.size());
153153
offset += entry.size();
154154
}
155155

@@ -165,7 +165,7 @@ namespace quicr {
165165
std::size_t offset = 0;
166166
std::size_t i = 0;
167167
for (auto& entry : entries_) {
168-
entries_[i++] = Span{ bytes_ }.subspan(offset, entry.size());
168+
entries_[i++] = Span<const uint8_t>{ bytes_ }.subspan(offset, entry.size());
169169
offset += entry.size();
170170
}
171171

src/transport_picoquic.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ PqEventCb(picoquic_cnx_t* pq_cnx,
166166
}
167167

168168
if (auto conn_ctx = transport->GetConnContext(conn_id)) {
169-
transport->OnRecvStreamBytes(conn_ctx, data_ctx, stream_id, Span{ bytes, length });
169+
transport->OnRecvStreamBytes(conn_ctx, data_ctx, stream_id, Span<const uint8_t>{ bytes, length });
170170

171171
if (is_fin) {
172172
SPDLOG_LOGGER_INFO(transport->logger, "Received FIN for stream {0}", stream_id);
@@ -1351,7 +1351,7 @@ PicoQuicTransport::OnRecvDatagram(ConnectionContext* conn_ctx, uint8_t* bytes, s
13511351
}
13521352

13531353
#if __cplusplus >= 202002L
1354-
if (conn_ctx->dgram_rx_data->Size() < 10 && !_cbNotifyQueue.Push([=, this]() {
1354+
if (conn_ctx->dgram_rx_data->Size() < 10 && !cbNotifyQueue_.Push([=, this]() {
13551355
#else
13561356
if (conn_ctx->dgram_rx_data->Size() < 10 && !cbNotifyQueue_.Push([=]() {
13571357
#endif

test/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ target_compile_options(quicr_test
2323

2424
set_target_properties(quicr_test
2525
PROPERTIES
26-
CXX_STANDARD 17
26+
CXX_STANDARD 20
2727
CXX_STANDARD_REQUIRED YES
2828
CXX_EXTENSIONS ON)
2929

test/uintvar.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ TEST_CASE("Encode/Decode UintVar Uint64")
3030

3131
TEST_CASE("Encode/Decode UintVar Bytes")
3232
{
33-
CHECK_EQ(var::kValue1Byte, uint64_t(quicr::UintVar(Span{ quicr::UintVar(var::kValue1Byte) })));
34-
CHECK_EQ(var::kValue2Byte, uint64_t(quicr::UintVar(Span{ quicr::UintVar(var::kValue2Byte) })));
35-
CHECK_EQ(var::kValue4Byte, uint64_t(quicr::UintVar(Span{ quicr::UintVar(var::kValue4Byte) })));
36-
CHECK_EQ(var::kValue8Byte, uint64_t(quicr::UintVar(Span{ quicr::UintVar(var::kValue8Byte) })));
33+
CHECK_EQ(var::kValue1Byte, uint64_t(quicr::UintVar(Span<const uint8_t>{ quicr::UintVar(var::kValue1Byte) })));
34+
CHECK_EQ(var::kValue2Byte, uint64_t(quicr::UintVar(Span<const uint8_t>{ quicr::UintVar(var::kValue2Byte) })));
35+
CHECK_EQ(var::kValue4Byte, uint64_t(quicr::UintVar(Span<const uint8_t>{ quicr::UintVar(var::kValue4Byte) })));
36+
CHECK_EQ(var::kValue8Byte, uint64_t(quicr::UintVar(Span<const uint8_t>{ quicr::UintVar(var::kValue8Byte) })));
3737
}
3838

3939
TEST_CASE("Length of UintVar")

0 commit comments

Comments
 (0)