Skip to content

Adding special slice attribute #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adding special slice attribute #391

wants to merge 4 commits into from
+53 −5

Conversation

weinbe58
Copy link
Member

@weinbe58 weinbe58 commented May 2, 2025 •
edited
Loading

closes #388

One issue here is a bit fragile is how to get the values out of const.Value nevermind I figured out a way to handle this.

After chatting we conclude that we have to have a speical runtime value for slice

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025 •
edited
Loading

PR Preview Action v1.6.1

🚀 View preview at
https://QuEraComputing.github.io/kirin/pr-preview/pr-391/

Built to branch gh-pages at 2025-05-02 16:25 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov Codecov
Copy link

codecov bot commented May 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.41935% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/kirin/dialects/py/slice.py 73.68% 5 Missing ⚠️
src/kirin/dialects/py/indexing.py 81.81% 2 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 2, 2025 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
9441 8304 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/kirin/dialects/py/indexing.py 87% 🟢
src/kirin/dialects/py/slice.py 90% 🟢
src/kirin/types.py 100% 🟢
TOTAL 93% 🟢

updated for commit: 85f89c9 by action🐍

@weinbe58 weinbe58 requested a review from Roger-luo May 2, 2025 14:23
@weinbe58 weinbe58 force-pushed the phil/slice-attr branch from 8d4dafa to 24f5160 Compare May 2, 2025 16:17
Roger-luo
Roger-luo requested changes May 2, 2025
View reviewed changes
Copy link
Member

@Roger-luo Roger-luo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have a test about this somewhere? there are quite a few lines missing tests.

@Roger-luo Roger-luo added the breaking breaking changes or proposed changes that would break existing APIs label May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roger-luo Roger-luo Roger-luo requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
breaking breaking changes or proposed changes that would break existing APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhashable built-in type: slice
2 participants
@weinbe58 @Roger-luo