Skip to content

fix: rewrite scf trim should update scf.for initializers and entries #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025

Conversation

Roger-luo
Copy link
Member

@Roger-luo Roger-luo commented Mar 24, 2025

partially fix #322 as this only corrects the generated code not triggering validation error but the code does not fold correctly

@Roger-luo Roger-luo added dialect:scf structural control flow related issue backport backport to latest release labels Mar 24, 2025
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/kirin/ir/nodes/block.py 75.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copy link
Contributor

github-actions bot commented Mar 24, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8974 7889 88% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/kirin/decl/emit/property.py 96% 🟢
src/kirin/dialects/scf/lowering.py 96% 🟢
src/kirin/dialects/scf/trim.py 94% 🟢
src/kirin/ir/nodes/block.py 80% 🟢
src/kirin/ir/ssa.py 90% 🟢
TOTAL 91% 🟢

updated for commit: 616b65b by action🐍

Copy link
Contributor

github-actions bot commented Mar 24, 2025

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-03-24 20:01 UTC

@Roger-luo Roger-luo merged commit 31f93ea into main Mar 24, 2025
11 checks passed
@Roger-luo Roger-luo deleted the roger/fix-scf-trim branch March 24, 2025 20:01
Roger-luo added a commit that referenced this pull request Mar 24, 2025
…331)

partially fix #322 as this only corrects the generated code not
triggering validation error but the code does not fold correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport backport to latest release dialect:scf structural control flow related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure to aggressively fold
1 participant