Add source distribution test cases

Author: messense

test-crates/lib_with_path_dep/.gitignore

@@ -62,6 +62,8 @@ pub fn pyo3_no_extension_module() -> Result<()> {
 ///
 /// https://github.com/PyO3/maturin/issues/472
 pub fn locked_doesnt_build_without_cargo_lock() -> Result<()> {
+    // rm Cargo.lock first
+    let _ = fs_err::remove_file("test-crates/lib_with_path_dep/Cargo.lock");
     // The first argument is ignored by clap
     let cli = vec![
         "build",

tests/common/errors.rs

@@ -1,6 +1,13 @@
-use anyhow::Result;
+use anyhow::{Context, Result};
+use cargo_metadata::MetadataCommand;
+use flate2::read::GzDecoder;
 use maturin::BuildOptions;
+use maturin::{source_distribution, CargoToml, Metadata21};
+use std::collections::HashSet;
+use std::iter::FromIterator;
+use std::path::Path;
 use structopt::StructOpt;
+use tar::Archive;
 
 /// Tries to compile a sample crate (pyo3-pure) for musl,
 /// given that rustup and the the musl target are installed
@@ -97,3 +104,42 @@ pub fn test_workspace_cargo_lock() -> Result<()> {
 
     Ok(())
 }
+
+pub fn test_source_distribution(
+    package: impl AsRef<Path>,
+    expected_files: Vec<&str>,
+) -> Result<()> {
+    let manifest_dir = package.as_ref();
+    let manifest_path = manifest_dir.join("Cargo.toml");
+    let cargo_toml = CargoToml::from_path(&manifest_path)?;
+    let metadata21 = Metadata21::from_cargo_toml(&cargo_toml, &manifest_dir)
+        .context("Failed to parse Cargo.toml into python metadata")?;
+    let cargo_metadata = MetadataCommand::new()
+        .manifest_path(&manifest_path)
+        .exec()
+        .context("Cargo metadata failed. Do you have cargo in your PATH?")?;
+
+    let sdist_directory = tempfile::tempdir()?;
+    let path = source_distribution(
+        &sdist_directory,
+        &metadata21,
+        &manifest_path,
+        &cargo_metadata,
+        None,
+    )
+    .context("Failed to build source distribution")?;
+
+    let tar_gz = fs_err::File::open(path)?;
+    let tar = GzDecoder::new(tar_gz);
+    let mut archive = Archive::new(tar);
+    let mut files = HashSet::new();
+    for entry in archive.entries()? {
+        let entry = entry?;
+        files.insert(format!("{}", entry.path()?.display()));
+    }
+    assert_eq!(
+        files,
+        HashSet::from_iter(expected_files.into_iter().map(ToString::to_string))
+    );
+    Ok(())
+}

tests/common/other.rs

@@ -152,3 +152,38 @@ fn musl() {
 fn workspace_cargo_lock() {
     handle_result(other::test_workspace_cargo_lock())
 }
+
+#[test]
+fn lib_with_path_dep_sdist() {
+    handle_result(other::test_source_distribution(
+        "test-crates/lib_with_path_dep",
+        vec![
+            "lib_with_path_dep-0.1.0/local_dependencies/some_path_dep/Cargo.toml",
+            "lib_with_path_dep-0.1.0/local_dependencies/some_path_dep/src/lib.rs",
+            "lib_with_path_dep-0.1.0/local_dependencies/transitive_path_dep/Cargo.toml",
+            "lib_with_path_dep-0.1.0/local_dependencies/transitive_path_dep/src/lib.rs",
+            "lib_with_path_dep-0.1.0/Cargo.toml",
+            "lib_with_path_dep-0.1.0/pyproject.toml",
+            "lib_with_path_dep-0.1.0/src/lib.rs",
+            "lib_with_path_dep-0.1.0/test.sh",
+            "lib_with_path_dep-0.1.0/PKG-INFO",
+        ],
+    ))
+}
+
+#[test]
+fn workspace_with_path_dep_sdist() {
+    handle_result(other::test_source_distribution(
+        "test-crates/workspace_with_path_dep/python",
+        vec![
+            "workspace_with_path_dep-0.1.0/local_dependencies/generic_lib/Cargo.toml",
+            "workspace_with_path_dep-0.1.0/local_dependencies/generic_lib/src/lib.rs",
+            "workspace_with_path_dep-0.1.0/local_dependencies/transitive_lib/Cargo.toml",
+            "workspace_with_path_dep-0.1.0/local_dependencies/transitive_lib/src/lib.rs",
+            "workspace_with_path_dep-0.1.0/Cargo.toml",
+            "workspace_with_path_dep-0.1.0/pyproject.toml",
+            "workspace_with_path_dep-0.1.0/src/lib.rs",
+            "workspace_with_path_dep-0.1.0/PKG-INFO",
+        ],
+    ))
+}