Pubwise 481 (#8)

* fixes for unit testing

Author: GLStephen

modules/pubwiseBidAdapter.js

@@ -94,11 +94,15 @@ export const spec = {
    * @return boolean True if this is a valid bid, and false otherwise.
    */
   isBidRequestValid: function (bid) {
-    if (bid.params && bid.params) {
+    // siteId is required
+    if (bid.params && bid.params.siteId) {
+      // it must be a string
       if (!utils.isStr(bid.params.siteId)) {
         _logWarn('siteId is required for bid', bid);
         return false;
       }
+    } else {
+      return false;
     }
 
     return true;

test/spec/modules/pubwiseBidAdapter_spec.js

@@ -496,30 +496,29 @@ describe('PubWiseAdapter', function () {
           bidder: 'pubwise',
           params: {
             siteId: 'xxxxxx',
-            placeHolder: ''
+            gender: 'M',
           }
         },
         isValid = spec.isBidRequestValid(validBid);
       expect(isValid).to.equal(true);
     });
 
     it('invalid bid: no siteId', function () {
-      let validBid = {
+      let inValidBid = {
           bidder: 'pubwise',
           params: {
-            placeHolder: ''
+            gender: 'M',
           }
         },
-        isValid = spec.isBidRequestValid(validBid);
+        isValid = spec.isBidRequestValid(inValidBid);
       expect(isValid).to.equal(false);
     });
 
-    it('invalid bid: siteId shuold be a sring', function () {
+    it('invalid bid: siteId should be a string', function () {
       let validBid = {
           bidder: 'pubwise',
           params: {
-            publisherId: 100000,
-            placeHolder: ''
+            siteId: 123456
           }
         },
         isValid = spec.isBidRequestValid(validBid);
@@ -530,7 +529,7 @@ describe('PubWiseAdapter', function () {
   describe('Handling Request Construction', function () {
     it('bid requests are not mutable', function() {
       let sourceBidRequest = utils.deepClone(sampleValidBidRequests)
-      let request = spec.buildRequests(sampleValidBidRequests, {auctinId: 'placeholder'});
+      spec.buildRequests(sampleValidBidRequests, {auctinId: 'placeholder'});
       expect(sampleValidBidRequests).to.deep.equal(sourceBidRequest, 'Should be unedited as they are used elsewhere');
     });
     it('should handle complex bidRequest', function() {