Skip to content

Commit 691216d

Browse files
Addressed review comments
1 parent 1b2940d commit 691216d

File tree

1 file changed

+5
-6
lines changed

1 file changed

+5
-6
lines changed

modules/pubmatic/openwrap/sdk/googlesdk/request.go

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,9 @@ import (
1616
"github.com/prebid/prebid-server/v3/util/ptrutil"
1717
)
1818

19-
const androidAppId = "com.google.ads.mediation.pubmatic.PubMaticMediationAdapter"
20-
const iOSAppId = "GADMediationAdapterPubMatic"
21-
2219
const (
20+
androidAppId = "com.google.ads.mediation.pubmatic.PubMaticMediationAdapter"
21+
iOSAppId = "GADMediationAdapterPubMatic"
2322
consentedProvidersSettingsListKey = "consented_providers_settings"
2423
consentedProvidersKey = "consented_providers"
2524
)
@@ -256,9 +255,6 @@ func modifyRequestWithStaticData(request *openrtb2.BidRequest) {
256255
request.Imp[0].Ext, _ = jsonparser.Set(request.Imp[0].Ext, []byte(strconv.Quote(request.Imp[0].TagID)), "gpid")
257256
}
258257

259-
// Remove metric
260-
request.Imp[0].Metric = nil
261-
262258
// Remove banner if impression is rewarded and banner and video both are present
263259
if request.Imp[0].Rwdd == 1 && request.Imp[0].Banner != nil && request.Imp[0].Video != nil {
264260
request.Imp[0].Banner = nil
@@ -272,6 +268,9 @@ func modifyRequestWithStaticData(request *openrtb2.BidRequest) {
272268
request.Imp[0].Banner.HMax = 0
273269
}
274270

271+
// Remove metric
272+
request.Imp[0].Metric = nil
273+
275274
// Remove native from request
276275
request.Imp[0].Native = nil
277276

0 commit comments

Comments
 (0)