Change Targting Key Prefix Constant

Author: pm-saurabh-narkhede

endpoints/openrtb2/ctv/util/util.go

@@ -18,6 +18,9 @@ import (
 	"github.com/prebid/prebid-server/v3/openrtb_ext"
 )
 
+// default targeting key prefix
+const DefaultKeyPrefix = "hb"
+
 var (
 	//prebid_ctv_errors
 	UnableToGenerateImpressionsError = &errortypes.AdpodPrefiltering{Message: `prebid_ctv unable to generate impressions for adpod`}
@@ -106,8 +109,7 @@ func TimeTrack(start time.Time, name string) {
 // if value not present or any error occured empty value will be returned
 // along with error.
 func GetTargeting(key openrtb_ext.TargetingKey, bidder openrtb_ext.BidderName, bid openrtb2.Bid) (string, error) {
-	hbtargetingPrefix := "hb"
-	bidderSpecificKey := key.BidderKey(hbtargetingPrefix, openrtb_ext.BidderName(bidder), 20)
+	bidderSpecificKey := key.BidderKey(DefaultKeyPrefix, openrtb_ext.BidderName(bidder), 20)
 	return jsonparser.GetString(bid.Ext, "prebid", "targeting", bidderSpecificKey)
 }
 

modules/pubmatic/openwrap/adpod/auction/auction.go

@@ -61,8 +61,7 @@ func FormAdpodBidsAndPerformExclusion(response *openrtb2.BidResponse, rctx model
 // if value not present or any error occured empty value will be returned
 // along with error.
 func GetTargeting(key openrtb_ext.TargetingKey, bidder openrtb_ext.BidderName, bid openrtb2.Bid) (string, error) {
-	hbtargetingPrefix := "hb"
-	bidderSpecificKey := key.BidderKey(hbtargetingPrefix, openrtb_ext.BidderName(bidder), 20)
+	bidderSpecificKey := key.BidderKey(models.DefaultTargetingKeyPrefix, openrtb_ext.BidderName(bidder), 20)
 	return jsonparser.GetString(bid.Ext, "prebid", "targeting", bidderSpecificKey)
 }
 
@@ -71,7 +70,7 @@ func addTargetingKey(bid *openrtb2.Bid, key openrtb_ext.TargetingKey, value stri
 		return errors.New("Invalid bid")
 	}
 
-	key = "hb" + key
+	key = models.DefaultTargetingKeyPrefix + key
 	raw, err := jsonparser.Set(bid.Ext, []byte(strconv.Quote(value)), "prebid", "targeting", string(key))
 	if err == nil {
 		bid.Ext = raw

modules/pubmatic/openwrap/models/constants.go

@@ -293,7 +293,7 @@ const (
 	HbBuyIdPrefix               = "hb_buyid_"
 	HbBuyIdPubmaticConstantKey  = "hb_buyid_pubmatic"
 	PwtBuyIdPubmaticConstantKey = "pwtbuyid_pubmatic"
-	HBTargetingKeyPrefix        = "hb"
+	DefaultTargetingKeyPrefix   = "hb"
 
 	SChainDBKey           = "sChain"
 	SChainObjectDBKey     = "sChainObj"

modules/pubmatic/openwrap/targeting.go

@@ -15,11 +15,11 @@ import (
 
 // whitelist of prebid targeting keys
 var prebidTargetingKeysWhitelist = map[string]struct{}{
-	models.HBTargetingKeyPrefix + string(openrtb_ext.PbKey):         {},
-	models.HBTargetingKeyPrefix + models.HbBuyIdPubmaticConstantKey: {},
+	models.DefaultTargetingKeyPrefix + string(openrtb_ext.PbKey): {},
+	models.HbBuyIdPubmaticConstantKey:                            {},
 	// OTT - 18 Deal priortization support
 	// this key required to send deal prefix and priority
-	models.HBTargetingKeyPrefix + string(openrtb_ext.CategoryDurationKey): {},
+	models.DefaultTargetingKeyPrefix + string(openrtb_ext.CategoryDurationKey): {},
 }
 
 // check if prebid targeting keys are whitelisted