[debian/rules] Fail on script error during package build (sonic-net#1050)

It is required to have -e in .SHELLFLAGS to fail on such errors.

Also, fixed install pathes for python bindings and disabled python2 bindings when DEB_BUILD_PROFILES=nopython2 is passed.

Signed-off-by: Stepan Blyschak [[email protected]](mailto:[email protected])

Author: stepanblyschak

.azure-pipelines/build-template.yml

@@ -114,7 +114,7 @@ jobs:
       set -ex
       rm ../*.deb || true
       ./autogen.sh
-      fakeroot debian/rules DEB_CONFIGURE_EXTRA_FLAGS='--enable-code-coverage' CFLAGS="" CXXFLAGS="" binary-syncd-vs
+      DEB_BUILD_OPTIONS=nocheck fakeroot debian/rules DEB_CONFIGURE_EXTRA_FLAGS='--enable-code-coverage' CFLAGS="" CXXFLAGS="" binary-syncd-vs
       mv ../*.deb .
     displayName: "Compile sonic sairedis with coverage enabled"
   - script: |

debian/control

@@ -117,6 +117,7 @@ Description: debugging symbols for libsaimetadata
 
 Package: python-pysairedis
 Architecture: any
+Build-Profiles: <!nopython2>
 Depends: ${shlibs:Depends}, ${misc:Pre-Depends}
 Section: libs
 Description: This package contains Switch State Service sairedis Python2 library.

debian/python-pysairedis.install

@@ -1 +1 @@
-usr/lib/python2.7/dist-packages/pysairedis/*
+usr/lib/python2.7/dist-packages/sairedis/*

debian/python3-pysairedis.install

@@ -1 +1 @@
-usr/lib/python3/dist-packages/pysairedis/*
+usr/lib/python3/dist-packages/sairedis/*

debian/rules

@@ -5,7 +5,7 @@
 
 .ONESHELL:
 SHELL = /bin/bash
-.SHELLFLAGS += -x
+.SHELLFLAGS += -ex
 
 # see EXAMPLES in dpkg-buildflags(1) and read /usr/share/dpkg/*
 DPKG_EXPORT_BUILDFLAGS = 1
@@ -29,6 +29,16 @@ endif
 # package maintainers to append LDFLAGS
 #export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed
 
+DOPACKAGES = $(shell dh_listpackages)
+
+# For Debian jessie, stretch, and buster, and Ubuntu bionic and focal, build
+# Python 2 bindings. This is controlled by the build profile being used.
+ifneq (,$(filter python-pysairedis,$(DOPACKAGES)))
+configure_opts += --enable-python2
+else
+configure_opts += --disable-python2
+endif
+
 clean:
 	dh $@ --with autotools-dev