Skip to content

Commit 0ed8e32

Browse files
Fix version feature handling (#572)
* Replace unsupported version with next supported version * add validity check --------- Co-authored-by: extremeheat <[email protected]>
1 parent 75fa085 commit 0ed8e32

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

src/connection.js

+4
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,22 @@ class Connection extends EventEmitter {
2828
}
2929

3030
versionLessThan (version) {
31+
if (typeof version === 'string' && !Versions[version]) throw Error('Unknown version: ' + version)
3132
return this.options.protocolVersion < (typeof version === 'string' ? Versions[version] : version)
3233
}
3334

3435
versionGreaterThan (version) {
36+
if (typeof version === 'string' && !Versions[version]) throw Error('Unknown version: ' + version)
3537
return this.options.protocolVersion > (typeof version === 'string' ? Versions[version] : version)
3638
}
3739

3840
versionGreaterThanOrEqualTo (version) {
41+
if (typeof version === 'string' && !Versions[version]) throw Error('Unknown version: ' + version)
3942
return this.options.protocolVersion >= (typeof version === 'string' ? Versions[version] : version)
4043
}
4144

4245
versionLessThanOrEqualTo (version) {
46+
if (typeof version === 'string' && !Versions[version]) throw Error('Unknown version: ' + version)
4347
return this.options.protocolVersion <= (typeof version === 'string' ? Versions[version] : version)
4448
}
4549

src/handshake/login.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ module.exports = (client, server, options) => {
6767
OverrideSkin: client.versionGreaterThanOrEqualTo('1.19.62') ? false : undefined,
6868
CompatibleWithClientSideChunkGen: client.versionGreaterThanOrEqualTo('1.19.80') ? false : undefined,
6969

70-
MaxViewDistance: client.versionGreaterThanOrEqualTo('1.21.40') ? 0 : undefined,
71-
MemoryTier: client.versionGreaterThanOrEqualTo('1.21.40') ? 0 : undefined,
72-
PlatformType: client.versionGreaterThanOrEqualTo('1.21.40') ? 0 : undefined
70+
MaxViewDistance: client.versionGreaterThanOrEqualTo('1.21.42') ? 0 : undefined,
71+
MemoryTier: client.versionGreaterThanOrEqualTo('1.21.42') ? 0 : undefined,
72+
PlatformType: client.versionGreaterThanOrEqualTo('1.21.42') ? 0 : undefined
7373
}
7474
const customPayload = options.skinData || {}
7575
payload = { ...payload, ...customPayload }

0 commit comments

Comments
 (0)