[FEATURE] Bump github actions to Ubuntu 24.04

[figueroa1395]

Describe the feature request

On October 30th, 2024, ubuntu-release will be fully migrated to ubuntu-24.04 for github actions. This feature request is about upgrading along to ubuntu-24.04. For reference here are the list packages, tools, etc. that come with this image and here is the announcement of this image and its implications.

Steps

This is the list of things that need to be done to do the full migration:

• Upgrade to ubuntu-24.04 (or ubuntu-release after October 30th) for github actions.
• Upgrade clang and clang-format to version 18.1.3. This involves also updating llvm to version 18.
• Upgrade gcc and g++ to version 13 (14 is experimental in ubuntu-24-04).
• Upgrade python to 3.12 in the github actions.
• Update pre-commit accordingly.
• Update build-guide (improving it is out of scope).
• Upgrade clang-tidy to version 18.1.3 and resolve all the resulting conflicts.

Experiment

An experiment was run on #770 to see what would the impact be to do the migration, and the main conclussions are:

• The validate-citations action initially broke. A quick fix is implemented in 7f8ee76.
• If clang-format is upgraded, the check-code-quality action breaks and many files need to be re-formatted again (also pre-commit needs to align with the versions here)
• If clang (but not clang-tidy) is upgraded, the clang-tidy action breaks horribly. If both clang and clang-tidy are upgraded, many fixes need to happen accross the core, as the clang-tidy action breaks. These probably need to be evaluated in a per-case scenario.

The above seem to be the only problems with the migration (without considering the cmakeupgrade which may be a follow up).

Takeout

The hard deadline to take action is October 30th, 2024, so we probably need to either address the above issues or pin github actions to ubuntu-22.04.

[figueroa1395]

Partially solved in #770. Only remaining task is to upgrade clang-tidy to 18.1.3. and to resolve all the resulting problems. This is to be done after taking action on a per-issue basis with the team.

[mgovers]

First attempt in #882

[figueroa1395]

@mgovers We can close this issue as completed in favor of having merged #882, correct? Before doing so, should I make a small PR to replace ubuntu-24.04 to ubuntu-latest? Only remaining is to update the runner on read the docs; I can quickly take a look if 24.04 is supported already there, and estimate the effort and value of doing so.

[mgovers]

@mgovers We can close this issue as completed in favor of having merged #882, correct? Before doing so, should I make a small PR to replace ubuntu-24.04 to ubuntu-latest? Only remaining is to update the runner on read the docs; I can quickly take a look if 24.04 is supported already there, and estimate the effort and value of doing so.

Yes, looks like everything worked. I actually think we can already close this. Readthedocs is a nice to have but less important (in the sense that: as long as it still builds, we're good to go). You can have a look indeed