add note about not handling groups

dmarticus · dmarticus · commit 71def6759039 · 2024-10-27T21:29:23.000-07:00
diff --git a/rust/feature-flags/src/cohort_operations.rs b/rust/feature-flags/src/cohort_operations.rs
@@ -57,6 +57,9 @@ impl Cohort {
     }
 
     /// Parses the filters JSON into a CohortProperty structure
+    // TODO: this doesn't handle the deprecated "groups" field, see
+    // https://github.com/PostHog/posthog/blob/feat/dynamic-cohorts-rust/posthog/models/cohort/cohort.py#L114-L169
+    // I'll handle that in a separate PR.
     pub fn parse_filters(&self) -> Result<Vec<PropertyFilter>, FlagError> {
         let wrapper: serde_json::Value = serde_json::from_value(self.filters.clone())?;
         let cohort_property: InnerCohortProperty =

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,9 @@ impl Cohort {`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`/// Parses the filters JSON into a CohortProperty structure`
	`60`	`+ // TODO: this doesn't handle the deprecated "groups" field, see`
	`61`	`+ // https://github.com/PostHog/posthog/blob/feat/dynamic-cohorts-rust/posthog/models/cohort/cohort.py#L114-L169`
	`62`	`+ // I'll handle that in a separate PR.`
`60`	`63`	`pub fn parse_filters(&self) -> Result<Vec<PropertyFilter>, FlagError> {`
`61`	`64`	`let wrapper: serde_json::Value = serde_json::from_value(self.filters.clone())?;`
`62`	`65`	`let cohort_property: InnerCohortProperty =`