chore: read $app_name from CFBundleDisplayName as a fallback if CFBundleName isn't available (#108)

marandaneto · web-flow · commit 504d5daa0486 · 2024-02-19T14:58:35.000+01:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,7 @@
 ## Next
 
+- read `$app_name` from `CFBundleDisplayName` as a fallback if `CFBundleName` isn't available [#108](https://github.com/PostHog/posthog-ios/pull/108)
+
 ## 3.1.4 - 2024-02-19
 
 - fix reset session when reset or close are called [#107](https://github.com/PostHog/posthog-ios/pull/107)
diff --git a/PostHog.xcodeproj/project.pbxproj b/PostHog.xcodeproj/project.pbxproj
@@ -1022,6 +1022,7 @@
 				DEVELOPMENT_TEAM = PNC2XCH2XP;
 				ENABLE_PREVIEWS = YES;
 				GENERATE_INFOPLIST_FILE = YES;
+				INFOPLIST_KEY_CFBundleDisplayName = "$(PRODUCT_NAME)";
 				INFOPLIST_KEY_UIApplicationSceneManifest_Generation = YES;
 				INFOPLIST_KEY_UIApplicationSupportsIndirectInputEvents = YES;
 				INFOPLIST_KEY_UILaunchScreen_Generation = YES;
@@ -1056,6 +1057,7 @@
 				DEVELOPMENT_TEAM = PNC2XCH2XP;
 				ENABLE_PREVIEWS = YES;
 				GENERATE_INFOPLIST_FILE = YES;
+				INFOPLIST_KEY_CFBundleDisplayName = "$(PRODUCT_NAME)";
 				INFOPLIST_KEY_UIApplicationSceneManifest_Generation = YES;
 				INFOPLIST_KEY_UIApplicationSupportsIndirectInputEvents = YES;
 				INFOPLIST_KEY_UILaunchScreen_Generation = YES;
diff --git a/PostHog/PostHogContext.swift b/PostHog/PostHogContext.swift
@@ -26,6 +26,8 @@ class PostHogContext {
 
         if let appName = infoDictionary?[kCFBundleNameKey as String] {
             properties["$app_name"] = appName
+        } else if let appName = infoDictionary?["CFBundleDisplayName"] {
+            properties["$app_name"] = appName
         }
         if let appVersion = infoDictionary?["CFBundleShortVersionString"] {
             properties["$app_version"] = appVersion

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,8 @@ class PostHogContext {`
`26`	`26`
`27`	`27`	`if let appName = infoDictionary?[kCFBundleNameKey as String] {`
`28`	`28`	`properties["$app_name"] = appName`
	`29`	`+ } else if let appName = infoDictionary?["CFBundleDisplayName"] {`
	`30`	`+ properties["$app_name"] = appName`
`29`	`31`	`}`
`30`	`32`	`if let appVersion = infoDictionary?["CFBundleShortVersionString"] {`
`31`	`33`	`properties["$app_version"] = appVersion`