Skip to content

Commit 2bb488c

Browse files
author
Steven Orvell
committed
closure fixes
1 parent 1125663 commit 2bb488c

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

lib/mixins/disable-upgrade-mixin.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,12 @@ export const DisableUpgradeMixin = dedupingMixin((base) => {
7676
*/
7777
class DisableUpgradeClass extends superClass {
7878

79+
constructor() {
80+
super();
81+
/** @type {boolean|undefined} */
82+
this.__isUpgradeDisabled;
83+
}
84+
7985
static get observedAttributes() {
8086
return observedAttributesGetter.call(this).concat(DISABLED_ATTR);
8187
}

lib/mixins/element-mixin.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -578,12 +578,12 @@ export const ElementMixin = dedupingMixin(base => {
578578
}
579579

580580
/**
581+
* Determines if a property dfeault can be applied. For example, this
582+
* prevents a default from being applied when a property that has no
583+
* accessor is overridden by its host before upgrade (e.g. via a binding).
581584
* @param {string} property Name of the property
582585
* @returns {boolean} Returns true if the property default can be applied.
583586
*/
584-
// A property default can be overridden when a `properties` property with
585-
// default but no effects had a property set (e.g. bound) by its host
586-
// before upgrade.
587587
_canApplyPropertyDefault(property) {
588588
return !this.hasOwnProperty(property);
589589
}

0 commit comments

Comments
 (0)