fix: add pooled balance to reserved with pool migrations

Author: Nick-1979

packages/extension-polkagate/src/hooks/useReservedDetails.ts

@@ -1,4 +1,4 @@
-// Copyright 2019-2024 @polkadot/extension-polkagate authors & contributors
+// Copyright 2019-2025 @polkadot/extension-polkagate authors & contributors
 // SPDX-License-Identifier: Apache-2.0
 
 // @ts-nocheck
@@ -13,18 +13,24 @@ import { useCallback, useEffect, useMemo, useState } from 'react';
 
 import { BN_ZERO } from '@polkadot/util';
 
-import { PROXY_CHAINS } from '../util/constants';
+import { MIGRATED_NOMINATION_POOLS_CHAINS, PROXY_CHAINS } from '../util/constants';
 import useActiveRecoveries from './useActiveRecoveries';
-import { useInfo } from '.';
+import { useAccountAssets, useInfo } from '.';
 
-type Item = 'identity' | 'proxy' | 'bounty' | 'recovery' | 'referenda' | 'index' | 'society' | 'multisig' | 'preimage';
+type Item = 'identity' | 'proxy' | 'bounty' | 'recovery' | 'referenda' | 'index' | 'society' | 'multisig' | 'preimage' | 'pooledBalance';
 export type Reserved = { [key in Item]?: Balance };
 
 export default function useReservedDetails (address: string | undefined): Reserved {
   const { api, formatted, genesisHash } = useInfo(address);
   const activeRecoveries = useActiveRecoveries(api);
+  const accountAssets = useAccountAssets(address);
+
   const [reserved, setReserved] = useState<Reserved>({});
 
+  const maybePooledBalance = useMemo(() =>
+    accountAssets?.find((balance) => balance.genesisHash === genesisHash)?.pooledBalance
+  , [accountAssets, genesisHash]);
+
   const activeLost = useMemo(() =>
     activeRecoveries && formatted
       ? activeRecoveries.filter((active) => active.lost === String(formatted)).at(-1) ?? null
@@ -274,10 +280,21 @@ export default function useReservedDetails (address: string | undefined): Reserv
           }
         }).catch(console.error);
       }
+
+      /** handle pooleBalance as reserved  */
+      if (maybePooledBalance && MIGRATED_NOMINATION_POOLS_CHAINS.includes(genesisHash)) {
+        if (!maybePooledBalance.isZero()) {
+          setReserved((prev) => {
+            prev.pooledBalance = toBalance(maybePooledBalance);
+
+            return prev;
+          });
+        }
+      }
     } catch (e) {
-      console.error('Fatal error while fetching reserved details:', e)
+      console.error('Fatal error while fetching reserved details:', e);
     }
-  }, [activeLost?.deposit, api, formatted, genesisHash, toBalance]);
+  }, [activeLost?.deposit, api, formatted, genesisHash, maybePooledBalance, toBalance]);
 
   useEffect(() => {
     setReserved({});

packages/extension-polkagate/src/popup/account/util.ts

@@ -1,4 +1,4 @@
-// Copyright 2019-2024 @polkadot/extension-polkagate authors & contributors
+// Copyright 2019-2025 @polkadot/extension-polkagate authors & contributors
 // SPDX-License-Identifier: Apache-2.0
 
 /**
@@ -10,6 +10,8 @@ import type { BalancesInfo } from '../../util/types';
 
 import { BN, BN_ZERO, bnMax } from '@polkadot/util';
 
+import { MIGRATED_NOMINATION_POOLS_CHAINS } from '../../util/constants';
+
 function isEmptyObject (obj: object): boolean {
   return Object.keys(obj).length === 0;
 }
@@ -22,8 +24,11 @@ export const getValue = (type: string, balances: BalancesInfo | null | undefined
   switch (type.toLocaleLowerCase()) {
     case ('total'):
     case ('total balance'):
+      // eslint-disable-next-line no-case-declarations
+      const isPoolsMigrated = MIGRATED_NOMINATION_POOLS_CHAINS.includes(balances.genesisHash);
+
       return balances?.freeBalance && balances.reservedBalance
-        ? new BN(balances.freeBalance).add(new BN(balances.reservedBalance)).add(balances?.pooledBalance ? new BN(balances.pooledBalance) : BN_ZERO)
+        ? new BN(balances.freeBalance).add(new BN(balances.reservedBalance)).add((balances?.pooledBalance && !isPoolsMigrated) ? new BN(balances.pooledBalance) : BN_ZERO)
         : new BN(balances?.totalBalance || 0);
     case ('pooled balance'):
     case ('pool stake'):

packages/extension-polkagate/src/util/constants.tsx

@@ -1,4 +1,4 @@
-// Copyright 2019-2024 @polkadot/extension-polkagate authors & contributors
+// Copyright 2019-2025 @polkadot/extension-polkagate authors & contributors
 // SPDX-License-Identifier: Apache-2.0
 
 import type { ProxyTypes } from './types';
@@ -53,7 +53,6 @@ export const POLKADOT_PEOPLE_GENESIS_HASH = '0x67fa177a097bfa18f77ea95ab56e9bcdf
 export const KUSAMA_PEOPLE_GENESIS_HASH = '0xc1af4cb4eb3918e5db15086c0cc5ec17fb334f728b7c65dd44bfe1e174ff8b3f';
 export const WESTEND_PEOPLE_GENESIS_HASH = '0x1eb6fb0ba5187434de017a70cb84d4f47142df1d571d0ef9e7e1407f2b80b93c';
 
-
 /** relay chains info */
 export const RELAY_CHAINS_NAMES = ['Polkadot', 'Kusama', 'Westend', 'Paseo'];
 
@@ -62,6 +61,8 @@ export const KUSAMA_GENESIS_HASH = '0xb0a8d493285c2df73290dfb7e61f870f17b4180119
 export const WESTEND_GENESIS_HASH = '0xe143f23803ac50e8f6f8e62695d1ce9e4e1d68aa36c1cd2cfd15340213f3423e';
 export const PASEO_GENESIS_HASH = '0x77afd6190f1554ad45fd0d31aee62aacc33c6db0ea801129acb813f913e0764f';
 
+export const MIGRATED_NOMINATION_POOLS_CHAINS = [WESTEND_GENESIS_HASH, KUSAMA_GENESIS_HASH];
+
 export const RELAY_CHAINS_GENESISHASH = [
   POLKADOT_GENESIS_HASH,
   KUSAMA_GENESIS_HASH,