cleaning up script

Author: Pietracoops

helpers.py

@@ -27,8 +27,11 @@ def listToStr(list):
 
     '''
     output_string = ""
-    for element in list:
-        output_string += element + " / "
+    for i in range(0, len(list)):
+        if i == 0:
+            output_string += list[i]
+        else:
+            output_string += "/" + list[i]
 
     return output_string
 
@@ -57,7 +60,7 @@ def outputCSV(filename, card_list, delimiter):
     for card in card_list:
         f.write(f"{card.card_passcode}{delimiter}{card.name}{delimiter}"
                 f"{card.card_status}{delimiter}{card.attribute}{delimiter}"
-                f"{card.type}{delimiter}{card.link}{delimiter}{card.link_arrows}{delimiter}"
+                f"{card.type}{delimiter}{card.link}{delimiter}{listToStr(card.link_arrows)}{delimiter}"
                 f"{card.rank}{delimiter}{card.pend_scale}{delimiter}"
                 f"{card.level}{delimiter}{card.attack}{delimiter}{card.defense}"
                 f"{delimiter}{card.spell_attribute}{delimiter}{card.summoning_condition}{delimiter}{card.pend_effect}"

main.py

@@ -137,8 +137,9 @@
                 tic = time.perf_counter()
                 if re.search('Passcode', ind_card_info.text):
                     lists = ind_card_info.find_all("td", class_="cardtablerowdata")
-                    passcode = lists[0]
-                    tmp_card.card_passcode = helpers.cleanStr(passcode.text, [("\n", ""), ("\t", ""), ("\r", "")])
+                    if len(lists) != 0:
+                        passcode = lists[0]
+                        tmp_card.card_passcode = helpers.cleanStr(passcode.text, [("\n", ""), ("\t", ""), ("\r", "")])
 
                 if re.search('Link Arrows', ind_card_info.text):
                     lists = ind_card_info.find_all("td", class_="cardtablerowdata")
@@ -152,17 +153,21 @@
 
                 if re.search('Card effect types', ind_card_info.text):
                     lists = ind_card_info.find_all("td", class_="cardtablerowdata")
-                    card_effect_types = lists[0]
-                    effect_types = []
-                    for effect_type in card_effect_types:
-                        if not isinstance(effect_type, NavigableString) and effect_type.text != '\n':
-                            effect_types.append(helpers.cleanStr(effect_type.text, [("\n", "")]))
-                    tmp_card.effect_types = effect_types
+                    if len(lists) != 0:
+                        card_effect_types = lists[0]
+                        effect_types = []
+                        for effect_type in card_effect_types:
+                            if not isinstance(effect_type, NavigableString) and effect_type.text != '\n':
+                                for effect in effect_type:
+                                    if effect.text not in effect_types and not re.search('\n', effect.text):
+                                        effect_types.append(effect.text)
+                        tmp_card.effect_types = effect_types
 
                 if re.search('Statuses', ind_card_info.text):
                     lists = ind_card_info.find_all("td", class_="cardtablerowdata")
-                    card_status = lists[0]
-                    tmp_card.card_status = helpers.cleanStr(card_status.text, [(" ", "")])
+                    if len(lists) != 0:
+                        card_status = lists[0]
+                        tmp_card.card_status = helpers.cleanStr(card_status.text, [(" ", "")])
 
                 if re.search('Card search categories', ind_card_info.text):
                     lists = ind_card_info.find_all("div", class_="hlist")
@@ -192,7 +197,7 @@
                             tmp_card.card_actions = card_actions
 
                 toc = time.perf_counter()
-                bar.text = f'-> Processing pack: {pack_name}, {tmp_card.name} processed in {toc - tic:0.4f} seconds'
+            bar.text = f'-> Processing pack: {pack_name}, {tmp_card.name} processed in {toc - tic:0.4f} seconds'
 
 
             # Store the card structure into the list of cards