Skip to content

Throw Error when rate limits are hit #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christroutner opened this issue Aug 9, 2021 · 0 comments
Open

Throw Error when rate limits are hit #164

christroutner opened this issue Aug 9, 2021 · 0 comments

Comments

@christroutner
Copy link
Contributor

When bch-js receives a 429 error from bch-api, it sometimes returns the error message as an object, rather than throwing an error. The proper behavior is to throw an error.

The scope of this Issue is to review the error handlers of endpoints and properly handle 429 errors. This code snippet of validateTxid3() captures how it catches and properly handles 429 errors:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant