Apply suggestions from code review

Author: mikemahoney218

R/download.R

@@ -135,7 +135,7 @@ rsi_download_rasters <- function(items,
                     "GDAL warp failed when attempting to merge ",
                     "{length(unlist(feature_iter))} items"
                   ),
-                  class = "download_warp_error", parent = e
+                  class = "rsi_download_warp_error", parent = e
                 )
               }
 
@@ -148,7 +148,7 @@ rsi_download_rasters <- function(items,
 
               # stop if failure occurs when there is only one item to download.
               if (length(feature_iter) == 1) {
-                rlang::abort(err_msg, class = "download_warp_error", parent = e)
+                rlang::abort(err_msg, class = "rsi_download_warp_error", parent = e)
               }
 
               # warn if failure occurs when multiple items are being downloaded.

R/get_stac_data.R

@@ -472,7 +472,7 @@ get_stac_data <- function(aoi,
 
   if (is.null(composite_function)) {
     app <- tryCatch(rstac::items_datetime(items), error = function(e) NA)
-    app <- gsub(":", "", app)
+    app <- gsub(":", "", app) # #29, #32
     if (any(is.na(app))) app <- NULL
     app <- app %||% as.character(seq_along(download_results))
     app <- make.unique(app, sep = "_")