fix: not properly apply filters

This commit fixes a bug that when seeking then later using only native filters, it would not continue from where it start (quick-filtering).

Author: ThePedroo

src/connection/voiceHandler.js

@@ -260,6 +260,7 @@ class VoiceConnection {
       const filter = new Filters()
       filter.configure(this.config.filters)
 
+      this.config.filters = {}
       filter.filters.forEach((filter) => {
         if (typeof filter.type !== 'number' && filter.name !== 'timescale') return;
 
@@ -346,6 +347,7 @@ class VoiceConnection {
     const filter = new Filters()
     filter.configure(filters, this.config.track.info)
 
+    this.config.filters = {}
     filter.filters.forEach((filter) => {
       if (typeof filter.type !== 'number' && filter.name !== 'timescale') return;
 

src/filters.js

@@ -193,7 +193,7 @@ class Filters {
         const startTime = this.filters.find((filter) => filter.name === 'seek')?.data
         const endTime = this.filters.find((filter) => filter.name === 'endTime')?.data
 
-        const isDecodedInternally = voiceUtils.isDecodedInternally(streamInfo.format)
+        const isDecodedInternally = voiceUtils.isDecodedInternally(currentStream, streamInfo.format)
         if (startTime === undefined && isDecodedInternally !== false && this.command.length === 0 && !endTime) {
           const filtersClasses = []
 
@@ -203,7 +203,7 @@ class Filters {
             filtersClasses.push(new filters.Interface(filter.type, filter.data))
           })
 
-          if (currentStream && !currentStream.ffmpeged) {
+          if (currentStream && (currentStream.ffmpegState !== 1 || !currentStream.ffmpegState)) {
             if (currentStream.filtersIndex.length === 0) {
               currentStream.detach()
               currentStream.pipes = addPartAt(currentStream.pipes, isDecodedInternally, filtersClasses)
@@ -229,7 +229,7 @@ class Filters {
 
             const pureStream = await sources.getTrackStream(decodedTrack, streamInfo.url, streamInfo.protocol)
 
-            const stream = new voiceUtils.createAudioResource(pureStream.stream, streamInfo.format, filterClasses, true)
+            const stream = new voiceUtils.createAudioResource(pureStream.stream, streamInfo.format, filterClasses, 0)
 
             resolve({ stream })
           }
@@ -282,7 +282,10 @@ class Filters {
               })
             )
 
-            resolve({ stream: new voiceUtils.NodeLinkStream(stream, pipelines, [], true) })
+            const onlySeeked = Object.keys(this.filters).length === 1 && this.filters.find((filter) => filter.name === 'seek')
+            const ffmpegState = (this.command.length !== 0 || !onlySeeked) ? 1 : 2
+
+            resolve({ stream: new voiceUtils.NodeLinkStream(stream, pipelines, ffmpegState) })
           })
         }
       } catch (err) {

src/voice/utils.js

@@ -4,7 +4,7 @@ import constants from '../../constants.js'
 import prism from 'prism-media'
 
 class NodeLinkStream {
-  constructor(stream, pipes, ffmpeged) {
+  constructor(stream, pipes, ffmpegState) {
     pipes.unshift(stream)
 
     for (let i = 0; i < pipes.length - 1; i++) {
@@ -18,7 +18,7 @@ class NodeLinkStream {
     this.listeners = []
     this.pipes = pipes
     this.filtersIndex = []
-    this.ffmpeged = ffmpeged
+    this.ffmpegState = ffmpegState
 
     /* @performanc/voice event */
     stream.on('finishBuffering', () => this.emit('finishBuffering'))
@@ -90,16 +90,16 @@ class NodeLinkStream {
   }
 }
 
-function isDecodedInternally(type) {
+function isDecodedInternally(stream, type) {
   switch (type) {
     case 'webm/opus':
-    case 'ogg/opus': return 3 + 1
-    case 'wav': return 2 + 1
+    case 'ogg/opus': return 3 + 1 + (stream.ffmpegState === 2 ? -2 : 0)
+    case 'wav': return 2 + 1 + (stream.ffmpegState === 2 ? -2 : 0)
     default: return false
   }
 }
 
-function createAudioResource(stream, type, additionalPipes = [], ffmpeged = false) {
+function createAudioResource(stream, type, additionalPipes = [], ffmpegState = false) {
   if ([ 'webm/opus', 'ogg/opus' ].includes(type)) {
     return new NodeLinkStream(stream, [
       new prism.opus[type === 'webm/opus' ? 'WebmDemuxer' : 'OggDemuxer'](),
@@ -111,7 +111,7 @@ function createAudioResource(stream, type, additionalPipes = [], ffmpeged = fals
         channels: constants.opus.channels,
         frameSize: constants.opus.frameSize
       })
-    ], ffmpeged)
+    ], ffmpegState)
   }
 
   if (type === 'wav') {
@@ -123,7 +123,7 @@ function createAudioResource(stream, type, additionalPipes = [], ffmpeged = fals
         channels: constants.opus.channels / 2,
         frameSize: constants.opus.frameSize / 2
       })
-    ], ffmpeged)
+    ], ffmpegState)
   }
 
   const ffmpeg = new prism.FFmpeg({
@@ -151,7 +151,7 @@ function createAudioResource(stream, type, additionalPipes = [], ffmpeged = fals
       channels: constants.opus.channels,
       frameSize: constants.opus.frameSize
     })
-  ], ffmpeged)
+  ], ffmpegState)
 }
 
 export default {