You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
running make check-tidy seems to be working fine on CI but running locally on a Mac machine fails with the following message (This is part of the output as it is very long)
[10/86] Building CXX object CMakeFiles/lightning_qubit_ops.dir/pennylane_lightning/core/bindings/Bindings.cpp.o
FAILED: CMakeFiles/lightning_qubit_ops.dir/pennylane_lightning/core/bindings/Bindings.cpp.o
/Users/mehrdad.malek/pennylane-lightning/venv/lib/python3.12/site-packages/cmake/data/bin/cmake -E __run_co_compile --launcher=/opt/homebrew/bin/ccache --tidy="clang-tidy;-extra-arg=-std=c++20;--extra-arg-before=--driver-mode=g++" --source=/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/bindings/Bindings.cpp -- /usr/bin/c++ -DSCIPY_OPENBLAS32_LIB=\"/Users/mehrdad.malek/pennylane-lightning/venv/lib/python3.12/site-packages/scipy_openblas32/lib\" -DVERSION_INFO="dynamic = [ \"version\",]" -Dlightning_qubit_ops_EXPORTS -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/utils -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/algorithms -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/base -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/utils -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/gates -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/observables -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/bindings -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/bindings -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/measurements -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/measurements -I/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/algorithms -isystem /Users/mehrdad.malek/pennylane-lightning/BuildTidy/_deps/pybind11-src/include -isystem /Library/Frameworks/Python.framework/Versions/3.12/include/python3.12 -O2 -g -DNDEBUG -std=gnu++20 -arch arm64 -mmacosx-version-min=11 -fPIC -fvisibility=hidden -Wall -Wextra -Werror -D_ENABLE_PLQUBIT=1 -MD -MT CMakeFiles/lightning_qubit_ops.dir/pennylane_lightning/core/bindings/Bindings.cpp.o -MF CMakeFiles/lightning_qubit_ops.dir/pennylane_lightning/core/bindings/Bindings.cpp.o.d -o CMakeFiles/lightning_qubit_ops.dir/pennylane_lightning/core/bindings/Bindings.cpp.o -c /Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/bindings/Bindings.cpp
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/algorithms/AdjointJacobianBase.hpp:183:68: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::shared_ptr<Observable<StateVectorT>>>
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/algorithms/JacobianData.hpp:69:5: error: constructor does not initialize these fields: num_par_ops_, num_nonpar_ops_, ops_name_, ops_inverses_ [hicpp-member-init,-warnings-as-errors]
OpsData(std::vector<std::string> ops_name,
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/algorithms/JacobianData.hpp:70:54: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::vector<PrecisionT>>&ops_params,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/algorithms/JacobianData.hpp:100:5: error: constructor does not initialize these fields: num_par_ops_, num_nonpar_ops_, ops_name_, ops_inverses_ [hicpp-member-init,-warnings-as-errors]
OpsData(std::vector<std::string> ops_name,
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/algorithms/JacobianData.hpp:101:54: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::vector<PrecisionT>>&ops_params,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/algorithms/JacobianData.hpp:127:5: error: constructor does not initialize these fields: num_par_ops_, num_nonpar_ops_, ops_name_, ops_inverses_ [hicpp-member-init,-warnings-as-errors]
OpsData(const std::vector<std::string>&ops_name,
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/algorithms/JacobianData.hpp:128:54: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::vector<PrecisionT>>&ops_params,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/algorithms/JacobianData.hpp:308:5: error: constructor does not initialize these fields: num_parameters, num_elements, trainableParams [hicpp-member-init,-warnings-as-errors]
JacobianData(std::size_t num_params, std::size_t num_elem,
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/algorithms/JacobianData.hpp:310:71: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
std::vector<std::shared_ptr<Observable<StateVectorT>>> obs,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/bindings/Bindings.hpp:22:10: error: 'set' file not found [clang-diagnostic-error]
#include <set>
^~~~~
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/bindings/Bindings.hpp:131:70: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const py::array_t<std::complex<typename StateVectorT::PrecisionT>>
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/bindings/Bindings.hpp:503:64: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::shared_ptr<Observable<StateVectorT>>> &observables,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/bindings/BindingsBase.hpp:37:70: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const py::array_t<std::complex<typename StateVectorT::PrecisionT>,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/bindings/BindingsBase.hpp:87:68: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const py::array_t<std::complex<typename TensorNetT::PrecisionT>,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/measurements/MeasurementsBase.hpp:69:5: error: constructor does not initialize these fields: _rng [hicpp-member-init,-warnings-as-errors]
explicit MeasurementsBase(const StateVectorT &statevector)
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/measurements/MeasurementsBase.hpp:482:59: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
std::vector<std::vector<PrecisionT>>&eigenValues)
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:156:5: error: constructor does not initialize these fields: obs_name_, wires_, params_ [hicpp-member-init,-warnings-as-errors]
NamedObsBase(std::string obs_name, std::vector<std::size_t> wires,
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:177:63: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
std::vector<std::vector<PrecisionT>>&eigenValues,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:271:5: error: constructor does not initialize these fields: matrix_, wires_, eigenVals_, unitary_ [hicpp-member-init,-warnings-as-errors]
HermitianObsBase(MatrixT matrix, std::vector<std::size_t> wires)
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:292:61: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
[[maybe_unused]] std::vector<std::vector<PrecisionT>>&eigenValues,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:311:7: error: constructor does not initialize these fields: all_wires_ [hicpp-member-init,-warnings-as-errors]
class TensorProdObsBase : public Observable<StateVectorT> {
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:323:20: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
returnfalse;~~~~~~~~~~~~~~~~~~~^~~~~~
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:342:5: error: constructor does not initialize these fields: all_wires_ [hicpp-member-init,-warnings-as-errors]
explicit TensorProdObsBase(Ts &&...arg) : obs_{std::forward<Ts>(arg)...} {
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:375:75: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
create(std::initializer_list<std::shared_ptr<Observable<StateVectorT>>> obs)
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:392:65: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
create(std::vector<std::shared_ptr<Observable<StateVectorT>>> obs)
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:429:63: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
std::vector<std::vector<PrecisionT>>&eigenValues,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:486:20: error: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr,-warnings-as-errors]
returnfalse;~~~~~~~~~~~~~~~~~~~^~~~~~
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:505:5: error: constructor does not initialize these fields: coeffs_ [hicpp-member-init,-warnings-as-errors]
HamiltonianBase(T1 &&coeffs, T2 &&obs)
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:523:75: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
std::initializer_list<std::shared_ptr<Observable<StateVectorT>>> obs)
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:537:61: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
[[maybe_unused]] std::vector<std::vector<PrecisionT>>&eigenValues,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:631:5: error: constructor does not initialize these fields: data_, indices_, offsets_, wires_ [hicpp-member-init,-warnings-as-errors]
SparseHamiltonianBase(T1 &&data, T2 &&indices, T3 &&offsets, T4 &&wires)
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/observables/Observables.hpp:669:61: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
[[maybe_unused]] std::vector<std::vector<PrecisionT>>&eigenValues,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/base/StateVectorBase.hpp:129:63: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::vector<std::size_t>>&ops_wires,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/base/StateVectorBase.hpp:161:68: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::vector<std::size_t>>&ops_wires,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/StateVectorLQubit.hpp:297:5: error: constructor does not initialize these fields: kernel_for_gates_, kernel_for_generators_, kernel_for_matrices_, kernel_for_sparse_matrices_, kernel_for_controlled_gates_, kernel_for_controlled_generators_, kernel_for_controlled_matrices_, kernel_for_controlled_sparse_matrices_ [hicpp-member-init,-warnings-as-errors]
explicit StateVectorLQubit(std::size_t num_qubits, Threading threading,
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/StateVectorLQubit.hpp:1020:49: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
&state](ComplexT *arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/StateVectorLQubitManaged.hpp:128:51: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::complex<PrecisionT>, Alloc>&other,
^
/*unused*/ /*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/StateVectorLQubitRaw.hpp:79:5: error: constructor does not initialize these fields: data_, length_ [hicpp-member-init,-warnings-as-errors]
StateVectorLQubitRaw(ComplexT *data, std::size_t length,
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/algorithms/AdjointJacobianLQubit.hpp:93:68: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::shared_ptr<Observable<StateVectorT>>>
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/bindings/LQubitBindings.hpp:123:70: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const py::array_t<std::complex<typename StateVectorT::PrecisionT>,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/DynamicDispatcher.hpp:538:5: error: function'isRegistered' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
bool isRegistered(ControlledGateOperation gate_op,
^
[[nodiscard]]
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/DynamicDispatcher.hpp:564:5: error: function'isRegistered' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
bool isRegistered(ControlledGeneratorOperation gen_op,
^
[[nodiscard]]
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/DynamicDispatcher.hpp:590:5: error: function'isRegistered' should be marked [[nodiscard]] [modernize-use-nodiscard,-warnings-as-errors]
bool isRegistered(ControlledMatrixOperation mat_op,
^
[[nodiscard]]
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/DynamicDispatcher.hpp:711:63: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::vector<std::size_t>>&wires,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/DynamicDispatcher.hpp:737:68: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::vector<std::size_t>>&wires,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/DynamicDispatcher.hpp:794:64: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::complex<PrecisionT>>&matrix,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/DynamicDispatcher.hpp:888:70: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::complex<PrecisionT>>&values,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/GateIndices.hpp:95:5: error: constructor does not initialize these fields: internal, external [hicpp-member-init,-warnings-as-errors]
GateIndices(const std::vector<std::size_t>&wires, std::size_t num_qubits)
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:472:63: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
&mat](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:530:60: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:577:45: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
applyPauliRot(std::complex<PrecisionT>*arr, std::size_t num_qubits,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:821:59: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:848:59: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:866:59: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:902:65: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [&shift](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:935:65: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [&shift](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:1016:61: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [&s](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:1047:61: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [&s](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:1290:66: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [&rotMat](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:1623:63: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [c, s](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:1665:50: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
[c, s, &e](std::complex<PrecisionT>*arr, const std::size_t i00,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:1707:50: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
[c, s, &e](std::complex<PrecisionT>*arr, const std::size_t i00,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:1746:64: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [phase](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:1868:48: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
[cr, sj](std::complex<PrecisionT>*arr, const std::size_t i0011,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:1901:61: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
&e](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:1938:61: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
&e](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2063:65: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [&phase](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2160:49: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
applyNCGenerator1(std::complex<PrecisionT>*arr, std::size_t num_qubits,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2254:46: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
[zero](std::complex<PrecisionT>*arr, const std::size_t i0,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2345:59: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2380:49: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
applyNCGenerator2(std::complex<PrecisionT>*arr, std::size_t num_qubits,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2471:46: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
[zero](std::complex<PrecisionT>*arr, const std::size_t i00,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2501:59: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2532:59: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2622:59: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
auto core_function = [](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2656:30: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
[zero](ComplexT *arr, const std::size_t i00, const std::size_t i01,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2697:49: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
applyNCGenerator4(std::complex<PrecisionT>*arr, std::size_t num_qubits,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2762:54: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
[&zero, &imag](std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2801:46: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
[imag](std::complex<PrecisionT>*arr, const std::size_t i0011,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2841:46: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
[imag](std::complex<PrecisionT>*arr, const std::size_t i0011,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/gates/cpu_kernels/GateImplementationsLM.hpp:2892:55: error: pointer parameter 'arr' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
applyNCGeneratorMultiRZ(std::complex<PrecisionT>*arr,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/measurements/ExpValFunc.hpp:276:69: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::complex<ParamT>>&matrix)
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/measurements/MeasurementKernels.hpp:325:5: error: constructor does not initialize these fields: n_probs_ [hicpp-member-init,-warnings-as-errors]
DiscreteRandomVariable(std::mt19937 &gen,
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/measurements/MeasurementsLQubit.hpp:351:59: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::vector<std::size_t>>&wires_list)
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/measurements/MeasurementsLQubit.hpp:522:56: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::vector<std::size_t>>&wires_list)
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/measurements/TransitionKernels.hpp:77:5: error: constructor does not initialize these fields: num_qubits_, rd_, gen_, distrib_num_qubits_, distrib_binary_ [hicpp-member-init,-warnings-as-errors]
explicit LocalTransitionKernel(std::size_t num_qubits)
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/measurements/TransitionKernels.hpp:120:5: error: constructor does not initialize these fields: rd_, gen_, distrib_, sv_length_, non_zeros_ [hicpp-member-init,-warnings-as-errors]
NonZeroRandomTransitionKernel(const std::complex<fp_t>*sv,
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/observables/ObservablesLQubit.hpp:137:75: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
create(std::initializer_list<std::shared_ptr<Observable<StateVectorT>>> obs)
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/observables/ObservablesLQubit.hpp:144:65: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
create(std::vector<std::shared_ptr<Observable<StateVectorT>>> obs)
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/observables/ObservablesLQubit.hpp:161:68: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::shared_ptr<Observable<StateVectorT>>> &terms,
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/observables/ObservablesLQubit.hpp:355:75: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
std::initializer_list<std::shared_ptr<Observable<StateVectorT>>> obs)
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/utils/LinearAlgebra.hpp:223:56: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
inline auto innerProd(const std::vector<std::complex<T>, AllocA>&v1,
^
/*unused*/ /*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/utils/LinearAlgebra.hpp:237:57: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
inline auto innerProdC(const std::vector<std::complex<T>, AllocA>&v1,
^
/*unused*/ /*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/utils/LinearAlgebra.hpp:258:55: error: pointer parameter 'v_out' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
std::complex<T>*v_out, std::size_t m,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/utils/LinearAlgebra.hpp:436:49: error: pointer parameter 'mat_t' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
std::complex<T>*mat_t, std::size_t m,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/simulators/lightning_qubit/utils/LinearAlgebra.hpp:626:48: error: pointer parameter 'm_out' can be pointer to const [readability-non-const-parameter,-warnings-as-errors]
std::complex<T>*m_out, std::size_t m,
^
const
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/utils/BLASLibLoaderManager.hpp:57:5: error: constructor does not initialize these fields: blasLib_ [hicpp-member-init,-warnings-as-errors]
explicit BLASLibLoaderManager() {
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/utils/ConstantUtil.hpp:47:61: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
constexpr auto lookup(const std::array<std::pair<Key, Value>, size>&arr,
^
/*unused*/ /*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/utils/ConstantUtil.hpp:69:54: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
reverse_lookup(const std::array<std::pair<Key, Value>, size>&arr,
^
/*unused*/ /*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/utils/ConstantUtil.hpp:109:54: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
array_contains(const std::array<std::pair<Key, Value>, size>&arr,
^
/*unused*/ /*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/utils/ConstantUtil.hpp:173:54: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
reverse_pairs_helper(const std::array<std::pair<T, U>, size>&arr,
^
/*unused*/ /*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/utils/Error.hpp:75:5: error: constructor does not initialize these fields: err_msg [hicpp-member-init,-warnings-as-errors]
explicit LightningException(std::string err_msg) noexcept
^
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/utils/Util.hpp:557:52: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::complex<T>>&mat) {
^
/*unused*/
/Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/utils/UtilLinearAlg.hpp:57:67: error: all parameters should be named in a function[hicpp-named-parameter,readability-named-parameter,-warnings-as-errors]
const std::vector<std::complex<T>>&Ah,
^
/*unused*/
Resource filename: /Users/mehrdad.malek/pennylane-lightning/venv/lib/python3.12/site-packages/clang_tidy/data/bin/clang-tidy
1929 warnings and 2 errors generated.
Error while processing /Users/mehrdad.malek/pennylane-lightning/pennylane_lightning/core/bindings/Bindings.cpp.
Suppressed 1804 warnings (1784 in non-user code, 20 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
103 warnings treated as errors
ninja: build stopped: subcommand failed.
make: *** [check-tidy] Error 1
The compiler used for building is shown below:
cmake -BBuildTidy -G Ninja \
-DENABLE_CLANG_TIDY=ON \
-DBUILD_TESTS=ON \
-DENABLE_WARNINGS=ON \
-DCLANG_TIDY_BINARY=clang-tidy \
-DPL_BACKEND="lightning_qubit" \
-DCMAKE_C_COMPILER_LAUNCHER=/opt/homebrew/bin/ccache \
-DCMAKE_CXX_COMPILER_LAUNCHER=/opt/homebrew/bin/ccache \
░█░░░▀█▀░█▀▀░█░█░▀█▀░█▀█░▀█▀░█▀█░█▀▀░
░█░░░░█░░█░█░█▀█░░█░░█░█░░█░░█░█░█░█░
░▀▀▀░▀▀▀░▀▀▀░▀░▀░░▀░░▀░▀░▀▀▀░▀░▀░▀▀▀░
-- The CXX compiler identification is AppleClang 16.0.0.16000026
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- pennylane_lightning version dynamic = [ "version",]
-- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES)
-- Could NOT find OpenMP (missing: OpenMP_CXX_FOUND)
-- PL_BACKEND: lightning_qubit
-- Using CLANG_TIDY_BINARY=clang-tidy
-- ENABLE_WARNINGS is ON.
-- ENABLE_OPENMP is OFF.
The text was updated successfully, but these errors were encountered:
running
make check-tidyseems to be working fine on CI but running locally on a Mac machine fails with the following message (This is part of the output as it is very long)The compiler used for building is shown below:
cmake -BBuildTidy -G Ninja \ -DENABLE_CLANG_TIDY=ON \ -DBUILD_TESTS=ON \ -DENABLE_WARNINGS=ON \ -DCLANG_TIDY_BINARY=clang-tidy \ -DPL_BACKEND="lightning_qubit" \ -DCMAKE_C_COMPILER_LAUNCHER=/opt/homebrew/bin/ccache \ -DCMAKE_CXX_COMPILER_LAUNCHER=/opt/homebrew/bin/ccache \ ░█░░░▀█▀░█▀▀░█░█░▀█▀░█▀█░▀█▀░█▀█░█▀▀░ ░█░░░░█░░█░█░█▀█░░█░░█░█░░█░░█░█░█░█░ ░▀▀▀░▀▀▀░▀▀▀░▀░▀░░▀░░▀░▀░▀▀▀░▀░▀░▀▀▀░ -- The CXX compiler identification is AppleClang 16.0.0.16000026 -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Check for working CXX compiler: /usr/bin/c++ - skipped -- Detecting CXX compile features -- Detecting CXX compile features - done -- pennylane_lightning version dynamic = [ "version",] -- Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES) -- Could NOT find OpenMP (missing: OpenMP_CXX_FOUND) -- PL_BACKEND: lightning_qubit -- Using CLANG_TIDY_BINARY=clang-tidy -- ENABLE_WARNINGS is ON. -- ENABLE_OPENMP is OFF.The text was updated successfully, but these errors were encountered: