catalyst.print incorrectly stacks multiple literals

[paul0403]

Since debug.print in frontend traces to callbacks instead of print_p now, I am using replace_ir to showcase this bug.

import catalyst
from catalyst import qjit, debug

@qjit(keep_intermediate=False)
def foo():
	return
foo()

new_ir = """
module @foo {
  func.func public @jit_foo() attributes {llvm.emit_c_interface} {
  	"catalyst.print"() {const_val = "Hello, Catalyst"} : () -> ()
  	"catalyst.print"() {const_val = "Hello again, Catalyst"} : () -> ()
    return
  }
  func.func @setup() {
    quantum.init
    return
  }
  func.func @teardown() {
    quantum.finalize
    return
  }
}
"""

debug.replace_ir(foo, "mlir", new_ir)
foo()

Hello, Catalyst@
Hello again, CatalystHello, Catalyst@

[erick-xanadu]

@paul0403 , is this stacking or just that the strings are not null terminated?

[paul0403]

The strings are not null terminated in the runtime stub.

[erick-xanadu]

It is kind of weird. We had this error in the past, but it was fixed... #404

[paul0403]

Just a note that the frontend pytest does not see this because

Since debug.print in frontend traces to callbacks instead of print_p now, I am using replace_ir to showcase this bug.

[paul0403]

Ahh, then the null terminator in in print primitive lowering (added in the fix #418) was not added!

[erick-xanadu]

Is it possible to print strings using the print_p primitive now from the frontend? Or is it only used for memrefs? Because if it is not reachable from the frontend, I would say that the error is in your program. Your strings are not null terminated.

[paul0403]

I think you are right, print_p without memrefs and only pure string literals is unreachable in the frontend.