Skip to content

Some comments on Accelerate LAPACKE integration #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lepus2589 opened this issue May 14, 2025 · 0 comments
Open

Some comments on Accelerate LAPACKE integration #1744

lepus2589 opened this issue May 14, 2025 · 0 comments

Comments

@lepus2589
Copy link

Following the interaction in #1726, I had a look at how Accelerate LAPACKE is integrated into the build. Here are my comments:

  1. You are referencing the master branch in runtime/CMakeLists.txt#L81. I'd strongly recommend a tag, as I can make no API stability guarantee for the master branch.
  2. Regarding runtime/CMakeLists.txt#L86: In my experience, you should never, ever move an installed CMake project from its intended install location (CMAKE_INSTALL_PREFIX) to somewhere else. This can also apply to binaries. CMake modifies the RPATH during the installation process. Do so at your own risk. If you absolutely have to, have a look at CMAKE_STAGING_PREFIX.
  3. You are only copying the binary dylib and check for its existence in subsequent runs (runtime/CMakeLists.txt#L78). Is there a reason you're not using the CMake config package provided by LAPACKE? You could use find_package(LAPACKE CONFIG PATHS "${CMAKE_BINARY_DIR}/_lapacke-accelerate/install" NO_DEFAULT_PATH) and then check the LAPACKE_FOUND variable. This would give you the lapacke imported CMake target for free.

Anyway, I'm happy my project is useful to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant