Remove repeat length check from SpanByte.Equals

PaulusParssinen · PaulusParssinen · commit a2a9a813d285 · 2025-03-21T16:57:12.000+02:00
diff --git a/libs/storage/Tsavorite/cs/src/core/VarLen/SpanByteComparer.cs b/libs/storage/Tsavorite/cs/src/core/VarLen/SpanByteComparer.cs
@@ -47,8 +47,7 @@ public static unsafe long StaticGetHashCode64(ref SpanByte spanByte)
         [MethodImpl(MethodImplOptions.AggressiveInlining)]
         public static unsafe bool StaticEquals(ref SpanByte k1, ref SpanByte k2)
         {
-            return k1.AsReadOnlySpanWithMetadata().SequenceEqual(k2.AsReadOnlySpanWithMetadata())
-                && (k1.MetadataSize == k2.MetadataSize);
+            return k1.AsReadOnlySpanWithMetadata().SequenceEqual(k2.AsReadOnlySpanWithMetadata());
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -47,8 +47,7 @@ public static unsafe long StaticGetHashCode64(ref SpanByte spanByte)`
`47`	`47`	`[MethodImpl(MethodImplOptions.AggressiveInlining)]`
`48`	`48`	`public static unsafe bool StaticEquals(ref SpanByte k1, ref SpanByte k2)`
`49`	`49`	`{`
`50`		`- return k1.AsReadOnlySpanWithMetadata().SequenceEqual(k2.AsReadOnlySpanWithMetadata())`
`51`		`- && (k1.MetadataSize == k2.MetadataSize);`
	`50`	`+ return k1.AsReadOnlySpanWithMetadata().SequenceEqual(k2.AsReadOnlySpanWithMetadata());`
`52`	`51`	`}`
`53`	`52`	`}`
`54`	`53`	`}`