A lot of perf micro-optimisations (#20188)

* Refactors Investigate Log

* Speedup character loading

* Optimise SSinstancing

* Removes both path images

* Optimises SSdebugview

* CRLF --> LF

* Update config/example/config.toml

Author: AffectedArc07

code/__DEFINES/hud.dm

@@ -26,7 +26,7 @@
 #define PLANT_WEED_HUD		"21"// Weed level
 #define DIAG_TRACK_HUD		"22"// Mech tracking beacon
 #define DIAG_AIRLOCK_HUD 	"23" // Airlock shock overlay
-#define DIAG_PATH_HUD 		"24"//Bot path indicators
+//#define DIAG_PATH_HUD 		"24"//Bot path indicators
 #define GLAND_HUD 			"25"//Gland indicators for abductors
 
 //by default everything in the hud_list of an atom is an image

code/_globalvars/logging.dm

@@ -49,4 +49,3 @@ GLOBAL_PROTECT(OOClog)
 
 GLOBAL_DATUM_INIT(logging, /datum/logging, new /datum/logging())
 
-GLOBAL_LIST_INIT(investigate_log_subjects, list("notes", "watchlist", "hrefs"))

code/controllers/configuration/sections/system_configuration.dm

@@ -22,6 +22,8 @@
 	var/list/topic_ip_ratelimit_bypass = list()
 	/// Server instance ID
 	var/instance_id = "paradise_main"
+	/// Do we want to enable instancing stuff at all?
+	var/enable_multi_instance_support = FALSE
 	/// Server internal IP
 	var/internal_ip = "127.0.0.1"
 	/// Are we using an external handler for TOS
@@ -36,6 +38,7 @@
 	CONFIG_LOAD_BOOL(shutdown_on_reboot, data["shutdown_on_reboot"])
 	CONFIG_LOAD_BOOL(is_production, data["is_production"])
 	CONFIG_LOAD_BOOL(external_tos_handler, data["external_tos_handler"])
+	CONFIG_LOAD_BOOL(enable_multi_instance_support, data["enable_multi_instance_support"])
 
 	CONFIG_LOAD_STR(topic_key, data["communications_password"])
 	CONFIG_LOAD_STR(medal_hub_address, data["medal_hub_address"])

code/controllers/subsystem/debugview.dm

@@ -7,6 +7,10 @@ SUBSYSTEM_DEF(debugview)
 	var/list/client/processing = list()
 
 /datum/controller/subsystem/debugview/fire(resumed)
+	// Dont generate text if no one is there to look at it
+	if(!length(processing))
+		return
+
 	// Generate debug text
 	var/list/entries = list()
 	entries += "CPU: [round(world.cpu, 1)] | MCPU: [round(world.map_cpu, 1)] | FPS/TPS: [world.fps] | Clients: [length(GLOB.clients)] | BYOND: [world.byond_version].[world.byond_build]"

code/controllers/subsystem/instancing.dm

@@ -14,7 +14,7 @@ SUBSYSTEM_DEF(instancing)
 		CRASH("SSinstancing was set to init before SSredis. Who broke it?")
 
 	// Dont even bother if we arent connected to redis or the DB
-	if(!SSdbcore.IsConnected() || !SSredis.connected)
+	if(!SSdbcore.IsConnected() || !SSredis.connected || !GLOB.configuration.system.enable_multi_instance_support)
 		flags |= SS_NO_FIRE
 		return ..()
 
@@ -43,6 +43,10 @@ SUBSYSTEM_DEF(instancing)
 	update_playercache()
 
 /datum/controller/subsystem/instancing/proc/execute_command(source, command, list/arguments)
+	// We aint enabled. Dont bother.
+	if(!GLOB.configuration.system.enable_multi_instance_support)
+		return
+
 	var/datum/server_command/SC = registered_commands[command]
 	if(!SC)
 		CRASH("Attempted to execute command with ID '[command]' from [source], but that command didnt exist!")
@@ -58,6 +62,10 @@ SUBSYSTEM_DEF(instancing)
   * Updates the player cache in the DB. Different from heartbeat so we can force invoke it on player operations
   */
 /datum/controller/subsystem/instancing/proc/update_playercache(optional_ckey)
+	// We aint enabled. Dont bother.
+	if(!GLOB.configuration.system.enable_multi_instance_support)
+		return
+
 	// You may be wondering, why the fuck is an "optional ckey" variable here
 	// Well, this is invoked in client/New(), and needs to read from GLOB.clients
 	// However, this proc sleeps, and if you sleep during client/New() once the client is in GLOB.clients, stuff breaks bad
@@ -111,6 +119,10 @@ SUBSYSTEM_DEF(instancing)
   * This is called during world/New() instead of on initialize so it can be done *instantly*
   */
 /datum/controller/subsystem/instancing/proc/seed_data()
+	// We aint enabled. Dont bother.
+	if(!GLOB.configuration.system.enable_multi_instance_support)
+		return
+
 	// We need to seed a lot of keys, so lets just use a key-value-pair-map to do this easily
 	var/list/kvp_map = list()
 	kvp_map["server_name"] = GLOB.configuration.general.server_name // Name of the server
@@ -145,6 +157,10 @@ SUBSYSTEM_DEF(instancing)
   * ckey - The ckey to check if they are logged into another server
   */
 /datum/controller/subsystem/instancing/proc/check_player(ckey)
+	// We aint enabled. Dont bother.
+	if(!GLOB.configuration.system.enable_multi_instance_support)
+		return
+
 	// Please see above rant on L127
 	var/datum/db_query/dbq1 = SSdbcore.NewQuery({"
 		SELECT server_id, key_value FROM instance_data_cache WHERE server_id IN

code/game/data_huds.dm

@@ -49,10 +49,7 @@
 	hud_icons = list(DIAG_HUD, DIAG_STAT_HUD, DIAG_BATT_HUD, DIAG_MECH_HUD, DIAG_BOT_HUD, DIAG_TRACK_HUD, DIAG_AIRLOCK_HUD)
 
 /datum/atom_hud/data/diagnostic/advanced
-	hud_icons = list(DIAG_HUD, DIAG_STAT_HUD, DIAG_BATT_HUD, DIAG_MECH_HUD, DIAG_BOT_HUD, DIAG_TRACK_HUD, DIAG_AIRLOCK_HUD, DIAG_PATH_HUD)
-
-/datum/atom_hud/data/bot_path
-	hud_icons = list(DIAG_PATH_HUD)
+	hud_icons = list(DIAG_HUD, DIAG_STAT_HUD, DIAG_BATT_HUD, DIAG_MECH_HUD, DIAG_BOT_HUD, DIAG_TRACK_HUD, DIAG_AIRLOCK_HUD)
 
 /datum/atom_hud/abductor
 	hud_icons = list(GLAND_HUD)

code/game/machinery/tcomms/_base.dm

@@ -149,7 +149,7 @@ GLOBAL_LIST_EMPTY(tcomms_machines)
   */
 /obj/machinery/tcomms/proc/log_action(user, msg, adminmsg = FALSE)
 	log_game("NTTC: [key_name(user)] [msg]")
-	log_investigate("[key_name(user)] [msg]", "nttc")
+	investigate_log("[key_name(user)] [msg]", "nttc")
 	if(adminmsg)
 		message_admins("[key_name_admin(user)] [msg]")
 /**

code/game/world.dm

@@ -58,8 +58,6 @@ GLOBAL_DATUM(test_runner, /datum/test_runner)
 
 	GLOB.timezoneOffset = text2num(time2text(0, "hh")) * 36000
 
-	investigate_reset()
-
 	update_status()
 
 	GLOB.space_manager.initialize() //Before the MC starts up

code/modules/admin/admin_investigate.dm

@@ -1,61 +1,31 @@
-//By Carnwennan
+// Atom investigate stuff
+// All of this is stored in a global list because its faster than file IO and we arent ram constrained like TG -aa07
+GLOBAL_LIST_EMPTY(investigate_log_wrapper)
+GLOBAL_PROTECT(investigate_log_wrapper)
 
-//This system was made as an alternative to all the in-game lists and variables used to log stuff in-game.
-//lists and variables are great. However, they have several major flaws:
-//Firstly, they use memory. TGstation has one of the highest memory usage of all the ss13 branches.
-//Secondly, they are usually stored in an object. This means that they aren't centralised. It also means that
-//the data is lost when the object is deleted! This is especially annoying for things like the singulo engine!
-#define INVESTIGATE_DIR "data/investigate/"
+/atom/proc/investigate_log(message, subject)
+	if(!message || !subject)
+		return
 
-//SYSTEM
-/proc/investigate_subject2file(subject)
-	return wrap_file("[INVESTIGATE_DIR][subject].html")
+	if(!(subject in GLOB.investigate_log_wrapper))
+		GLOB.investigate_log_wrapper[subject] = list()
 
-/proc/investigate_reset()
-	if(fdel(INVESTIGATE_DIR))	return 1
-	return 0
-
-/atom/proc/investigate_log(message, subject)
-	if(!message)	return
-	var/F = investigate_subject2file(subject)
-	if(!F)	return
-	GLOB.investigate_log_subjects |= subject
-	F << "<small>[time_stamp()] \ref[src] [ADMIN_COORDJMP(src)] </small> || [src] [message]<br>"
-
-/proc/log_investigate(message, subject)
-	if(!message) return
-	var/F = investigate_subject2file(subject)
-	if(!F) return
-	GLOB.investigate_log_subjects |= subject
-	F << "<small>[time_stamp()] || [message]<br>"
+	GLOB.investigate_log_wrapper[subject] += "<small>[time_stamp()] [UID()] [ADMIN_COORDJMP(src)] </small> || [src] [message]"
 
 //ADMINVERBS
-/client/proc/investigate_show( subject in GLOB.investigate_log_subjects )
-	set name = "Investigate"
+/client/proc/investigate_show(subject in GLOB.investigate_log_wrapper)
+	set name = "Investigate Round Objects"
 	set category = "Admin"
+
 	if(!check_rights(R_ADMIN))
 		return
-	switch(subject)
-		if("notes")
-			show_note()
-
-		if("watchlist")
-			watchlist_show()
-
-		if("hrefs")				//persistant logs and stuff
-			if(GLOB.configuration.logging.href_logging)
-				if(GLOB.world_href_log)
-					src << browse(file(GLOB.world_href_log), "window=investigate[subject];size=800x300")
-				else
-					to_chat(src, "<font color='red'>Error: admin_investigate: No href logfile found.</font>")
-					return
-			else
-				to_chat(src, "<font color='red'>Error: admin_investigate: Href Logging is not on.</font>")
-				return
-
-		else //general one-round-only stuff
-			var/F = investigate_subject2file(subject)
-			if(!F)
-				to_chat(src, "<font color='red'>Error: admin_investigate: [INVESTIGATE_DIR][subject] is an invalid path or cannot be accessed.</font>")
-				return
-			src << browse(F,"window=investigate[subject];size=800x300")
+
+	// Should never happen
+	if(!(subject in GLOB.investigate_log_wrapper))
+		return
+
+	var/list/entries = GLOB.investigate_log_wrapper[subject]
+
+	var/datum/browser/B = new(usr, "investigatelog", "Investigate ([subject])", 800, 400)
+	B.set_content(entries.Join("<br>"))
+	B.open()

code/modules/admin/admin_verbs.dm

@@ -69,7 +69,8 @@ GLOBAL_LIST_INIT(admin_verbs_admin, list(
 	/client/proc/ccbdb_lookup_ckey,
 	/client/proc/view_instances,
 	/client/proc/start_vote,
-	/client/proc/ping_all_admins
+	/client/proc/ping_all_admins,
+	/client/proc/show_watchlist
 ))
 GLOBAL_LIST_INIT(admin_verbs_ban, list(
 	/client/proc/ban_panel,
@@ -996,3 +997,12 @@ GLOBAL_LIST_INIT(admin_verbs_maintainer, list(
 
 	log_admin("[key_name(usr)] has [advanced_admin_interaction ? "activated" : "deactivated"] their advanced admin interaction.")
 	message_admins("[key_name_admin(usr)] has [advanced_admin_interaction ? "activated" : "deactivated"] their advanced admin interaction.")
+
+/client/proc/show_watchlist()
+	set name = "Show Watchlist"
+	set category = "Admin"
+
+	if(!check_rights(R_ADMIN))
+		return
+
+	watchlist_show()

code/modules/atmospherics/machinery/components/binary_devices/pump.dm

@@ -35,17 +35,21 @@ Thus, the two variables affect pump operation are set in New():
 /obj/machinery/atmospherics/binary/pump/CtrlClick(mob/living/user)
 	if(can_use_shortcut(user))
 		toggle(user)
+		investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 	return ..()
 
 /obj/machinery/atmospherics/binary/pump/AICtrlClick(mob/living/silicon/user)
 	toggle(user)
+	investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/binary/pump/AltClick(mob/living/user)
 	if(can_use_shortcut(user))
 		set_max(user)
+		investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/binary/pump/AIAltClick(mob/living/silicon/user)
 	set_max(user)
+	investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/binary/pump/on
 	icon_state = "map_on"

code/modules/atmospherics/machinery/components/binary_devices/volume_pump.dm

@@ -32,17 +32,21 @@ Thus, the two variables affect pump operation are set in New():
 /obj/machinery/atmospherics/binary/volume_pump/CtrlClick(mob/living/user)
 	if(can_use_shortcut(user))
 		toggle(user)
+		investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 	return ..()
 
 /obj/machinery/atmospherics/binary/volume_pump/AICtrlClick(mob/living/silicon/user)
 	toggle(user)
+	investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/binary/volume_pump/AltClick(mob/living/user)
 	if(can_use_shortcut(user))
 		set_max(user)
+		investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/binary/volume_pump/AIAltClick(mob/living/silicon/user)
 	set_max(user)
+	investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/binary/volume_pump/on
 	on = TRUE

code/modules/atmospherics/machinery/components/trinary_devices/filter.dm

@@ -38,17 +38,21 @@
 /obj/machinery/atmospherics/trinary/filter/CtrlClick(mob/living/user)
 	if(can_use_shortcut(user))
 		toggle(user)
+		investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 	return ..()
 
 /obj/machinery/atmospherics/trinary/filter/AICtrlClick(mob/living/silicon/user)
 	toggle(user)
+	investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/trinary/filter/AltClick(mob/living/user)
 	if(can_use_shortcut(user))
 		set_max(user)
+		investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/trinary/filter/AIAltClick(mob/living/silicon/user)
 	set_max(user)
+	investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/trinary/filter/flipped
 	icon_state = "mmap"

code/modules/atmospherics/machinery/components/trinary_devices/mixer.dm

@@ -19,17 +19,21 @@
 /obj/machinery/atmospherics/trinary/mixer/CtrlClick(mob/living/user)
 	if(can_use_shortcut(user))
 		toggle(user)
+		investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 	return ..()
 
 /obj/machinery/atmospherics/trinary/mixer/AICtrlClick(mob/living/silicon/user)
 	toggle(user)
+	investigate_log("was turned [on ? "on" : "off"] by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/trinary/mixer/AltClick(mob/living/user)
 	if(can_use_shortcut(user))
 		set_max(user)
+		investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/trinary/mixer/AIAltClick(mob/living/silicon/user)
 	set_max(user)
+	investigate_log("was set to [target_pressure] kPa by [key_name(user)]", "atmos")
 
 /obj/machinery/atmospherics/trinary/mixer/flipped
 	icon_state = "mmap"

code/modules/client/preference/character.dm

@@ -103,7 +103,6 @@
 
 // Fuckery to prevent null characters
 /datum/character_save/New()
-	randomise()
 	real_name = random_name(gender, species)
 
 /datum/character_save/proc/save(client/C)