Skip to content

Commit cfec867

Browse files
committed
suggestion-1
1 parent 57ae541 commit cfec867

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

.github/workflows/pull-request.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,7 @@ jobs:
304304
uses: actions/checkout@v4
305305

306306
- name: Set up Node.js
307-
- uses: actions/setup-node@v4
307+
uses: actions/setup-node@v4
308308
with:
309309
node-version: '22.x'
310310

@@ -365,7 +365,7 @@ jobs:
365365
366366
# Wait for TALAWA API to be healthy
367367
timeout=60
368-
until docker-compose -f docker-compose.dev.yaml exec -T talawa-api-dev curl -sf "http://talawa-api-dev:4000/health" 2>&1 || [ $timeout -eq 0 ]; do
368+
until docker-compose -f docker-compose.dev.yaml exec -T talawa-api-dev curl -sf "http://localhost:4000/health" 2>&1 || [ $timeout -eq 0 ]; do
369369
echo "Waiting for API to start... ($timeout seconds remaining)"
370370
sleep 1
371371
((timeout--))
@@ -382,11 +382,12 @@ jobs:
382382

383383
# Ensure cleanup runs even if the script fails
384384
cleanup() {
385+
local exit_code=$?
385386
echo "Cleaning up containers..."
386387
if ! docker-compose -f docker-compose.dev.yaml down -v; then
387388
echo "Warning: Failed to cleanup containers"
388389
fi
389-
}
390+
exit $exit_code }
390391

391392
trap cleanup EXIT
392393
env:

0 commit comments

Comments
 (0)